Bug 46298 - Add logicalWidth/Height getters and setters to RenderBox
Summary: Add logicalWidth/Height getters and setters to RenderBox
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks: 46123
  Show dependency treegraph
 
Reported: 2010-09-22 13:18 PDT by Dave Hyatt
Modified: 2010-09-22 13:27 PDT (History)
0 users

See Also:


Attachments
Patch (2.48 KB, patch)
2010-09-22 13:22 PDT, Dave Hyatt
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-09-22 13:18:13 PDT
Add logicalWidth/Height getters and setters to RenderBox.
Comment 1 Dave Hyatt 2010-09-22 13:22:43 PDT
Created attachment 68428 [details]
Patch
Comment 2 mitz 2010-09-22 13:24:42 PDT
Comment on attachment 68428 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68428&action=review

> WebCore/rendering/RenderBox.cpp:90
> +    if (style()->isVerticalBlockFlow())
> +        return width();
> +    return height();

Maybe now it’s too late to say this, but how about
return style()->isVerticalBlockFlow() ? width() : height();
instead?
Comment 3 Dave Hyatt 2010-09-22 13:26:56 PDT
(In reply to comment #2)
> (From update of attachment 68428 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=68428&action=review
> 
> > WebCore/rendering/RenderBox.cpp:90
> > +    if (style()->isVerticalBlockFlow())
> > +        return width();
> > +    return height();
> 
> Maybe now it’s too late to say this, but how about
> return style()->isVerticalBlockFlow() ? width() : height();
> instead?

Not too late. :)
Comment 4 Dave Hyatt 2010-09-22 13:27:39 PDT
Fixed in r68077.