WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
46298
Add logicalWidth/Height getters and setters to RenderBox
https://bugs.webkit.org/show_bug.cgi?id=46298
Summary
Add logicalWidth/Height getters and setters to RenderBox
Dave Hyatt
Reported
2010-09-22 13:18:13 PDT
Add logicalWidth/Height getters and setters to RenderBox.
Attachments
Patch
(2.48 KB, patch)
2010-09-22 13:22 PDT
,
Dave Hyatt
mitz: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dave Hyatt
Comment 1
2010-09-22 13:22:43 PDT
Created
attachment 68428
[details]
Patch
mitz
Comment 2
2010-09-22 13:24:42 PDT
Comment on
attachment 68428
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=68428&action=review
> WebCore/rendering/RenderBox.cpp:90 > + if (style()->isVerticalBlockFlow()) > + return width(); > + return height();
Maybe now it’s too late to say this, but how about return style()->isVerticalBlockFlow() ? width() : height(); instead?
Dave Hyatt
Comment 3
2010-09-22 13:26:56 PDT
(In reply to
comment #2
)
> (From update of
attachment 68428
[details]
) > View in context:
https://bugs.webkit.org/attachment.cgi?id=68428&action=review
> > > WebCore/rendering/RenderBox.cpp:90 > > + if (style()->isVerticalBlockFlow()) > > + return width(); > > + return height(); > > Maybe now it’s too late to say this, but how about > return style()->isVerticalBlockFlow() ? width() : height(); > instead?
Not too late. :)
Dave Hyatt
Comment 4
2010-09-22 13:27:39 PDT
Fixed in
r68077
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug