RESOLVED FIXED 46291
Add AudioChannelMerger files 
https://bugs.webkit.org/show_bug.cgi?id=46291
Summary Add AudioChannelMerger files
Chris Rogers
Reported 2010-09-22 12:15:24 PDT
Add AudioChannelMerger files
Attachments
Patch (9.62 KB, patch)
2010-09-22 12:16 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Patch (9.38 KB, patch)
2010-09-28 16:13 PDT, Chris Rogers 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Chris Rogers
Comment 1 2010-09-22 12:16:16 PDT
Created attachment 68415 [details] Patch
Chris Rogers
Comment 2 2010-09-22 12:18:51 PDT
This is the implementation for AudioChannelMerger as described in the web audio API: http://chromium.googlecode.com/svn/trunk/samples/audio/specification/specification.html#AudioChannelMerger-section
Kenneth Russell
Comment 3 2010-09-28 10:36:14 PDT
Comment on attachment 68415 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68415&action=review Looks good overall, but r- for similar issues as in AudioChannelSplitter. > WebCore/webaudio/AudioChannelMerger.cpp:40 > +// This is considering that 5.1 (6 channels is the largest we'll ever deal with). Same issue with comment as in AudioChannelSplitter. > WebCore/webaudio/AudioChannelMerger.cpp:86 > + outputChannelIndex++; Use preincrement. > WebCore/webaudio/AudioChannelMerger.cpp:98 > +void AudioChannelMerger::initialize() Refactor these into AudioNode.
Chris Rogers
Comment 4 2010-09-28 16:13:15 PDT
Created attachment 69125 [details] Patch
Chris Rogers
Comment 5 2010-09-28 16:14:05 PDT
Comment on attachment 68415 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68415&action=review >> WebCore/webaudio/AudioChannelMerger.cpp:40 >> +// This is considering that 5.1 (6 channels is the largest we'll ever deal with). > > Same issue with comment as in AudioChannelSplitter. FIXED >> WebCore/webaudio/AudioChannelMerger.cpp:86 >> + outputChannelIndex++; > > Use preincrement. FIXED >> WebCore/webaudio/AudioChannelMerger.cpp:98 >> +void AudioChannelMerger::initialize() > > Refactor these into AudioNode. FIXED
Kenneth Russell
Comment 6 2010-09-29 15:14:09 PDT
Comment on attachment 69125 [details] Patch Looks good.
WebKit Commit Bot
Comment 7 2010-09-29 17:55:13 PDT
Comment on attachment 69125 [details] Patch Clearing flags on attachment: 69125 Committed r68732: <http://trac.webkit.org/changeset/68732>
WebKit Commit Bot
Comment 8 2010-09-29 17:55:19 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.