Bug 46288 - [EFL] Tiled backing store support for scaling
Summary: [EFL] Tiled backing store support for scaling
Status: RESOLVED INVALID
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-22 12:06 PDT by Alex Bredariol Grilo
Modified: 2014-08-20 12:12 PDT (History)
8 users (show)

See Also:


Attachments
Patch (29.21 KB, patch)
2010-09-22 12:10 PDT, Alex Bredariol Grilo
kenneth: review-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Alex Bredariol Grilo 2010-09-22 12:06:30 PDT
[EFL] Tiled backing store support for scaling
Comment 1 Alex Bredariol Grilo 2010-09-22 12:10:29 PDT
Created attachment 68413 [details]
Patch
Comment 2 Kenneth Rohde Christiansen 2010-12-24 02:42:55 PST
Comment on attachment 68413 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68413&action=review

> WebKit/efl/ewk/ewk_tiled_backing_store.c:1886
> +    /*
> +    if (model_width < priv->view.w ||
> +        ((int)base_col <= -1 && new_x >= 0)) {
> +        base_col = -1;
> +        new_x = 0;
> +        bx = -tw;
> +    } else if ((int)base_col >= last_visible_left_col - 1 &&
> +               new_x < -model_width + priv->view.w) {
> +        new_x = -model_width + priv->view.w;
> +        bx = new_x % tw - tw;
> +        base_col = -new_x / tw - 1;
> +    }
> +
> +    if (model_height < priv->view.h ||
> +        ((int)base_row <= -1 && new_y >= 0)) {
> +        base_row = -1;
> +        new_y = 0;
> +        by = -th;
> +    } else if ((int)base_row >= last_visible_top_row - 1 &&
> +               new_y < -model_height + priv->view.h) {
> +        new_y = -model_height + priv->view.h;
> +        by = new_y % th - th;
> +        base_row = -new_y / th - 1;
> +    }
> +    */

We DO NOT commit uncommented code. r- due to this alone.

> WebKit/efl/ewk/ewk_view_tiled.c:84
> +        x = x / zoom;

Why are we mixing zoom and scale?

> WebKitTools/EWebLauncher/main.c:113
> +            ('C', "cairo-scaling", "use cairo scaling instead of webkit.", 1),

WebKit doesn't support scaling, though I believe some support was recently added to WebCore. There is a difference between scaling and zooming, for instance with zooming we are not just scaling the RenderTheme
Comment 3 Ryuan Choi 2011-09-22 01:31:54 PDT
Close bug because WebCore already support same behavior.