[EFL] Tiled backing store support for scaling
Created attachment 68413 [details] Patch
Comment on attachment 68413 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68413&action=review > WebKit/efl/ewk/ewk_tiled_backing_store.c:1886 > + /* > + if (model_width < priv->view.w || > + ((int)base_col <= -1 && new_x >= 0)) { > + base_col = -1; > + new_x = 0; > + bx = -tw; > + } else if ((int)base_col >= last_visible_left_col - 1 && > + new_x < -model_width + priv->view.w) { > + new_x = -model_width + priv->view.w; > + bx = new_x % tw - tw; > + base_col = -new_x / tw - 1; > + } > + > + if (model_height < priv->view.h || > + ((int)base_row <= -1 && new_y >= 0)) { > + base_row = -1; > + new_y = 0; > + by = -th; > + } else if ((int)base_row >= last_visible_top_row - 1 && > + new_y < -model_height + priv->view.h) { > + new_y = -model_height + priv->view.h; > + by = new_y % th - th; > + base_row = -new_y / th - 1; > + } > + */ We DO NOT commit uncommented code. r- due to this alone. > WebKit/efl/ewk/ewk_view_tiled.c:84 > + x = x / zoom; Why are we mixing zoom and scale? > WebKitTools/EWebLauncher/main.c:113 > + ('C', "cairo-scaling", "use cairo scaling instead of webkit.", 1), WebKit doesn't support scaling, though I believe some support was recently added to WebCore. There is a difference between scaling and zooming, for instance with zooming we are not just scaling the RenderTheme
Close bug because WebCore already support same behavior.