Inside WebKit/gtk/tests/testatk.c, there are still some places where the following kind of lines g_timeout_add(100, (GSourceFunc)bail_out, loop); ...should be replaced by a call to g_idle_add: g_idle_add((GSourceFunc)bail_out, loop); This is a trivial-yet-needed bug that needs obvious fixing (and further care when adding new tests <- note to myself :-/)
Created attachment 68419 [details] Patch proposal This should be straightforward I guess...
Comment on attachment 68419 [details] Patch proposal View in context: https://bugs.webkit.org/attachment.cgi?id=68419&action=review > WebKit/gtk/ChangeLog:8 > + Use g_idle_add() whenever g_timeout_add() was being used You should explain here why this conversion is a good thing. In the future, other programmers will see this commit and wonder what the explanation was. We should be able to concisely describe to people why we prefer this style.
Created attachment 68430 [details] Patch proposal (In reply to comment #2) > (From update of attachment 68419 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=68419&action=review > > > WebKit/gtk/ChangeLog:8 > > + Use g_idle_add() whenever g_timeout_add() was being used > > You should explain here why this conversion is a good thing. In the future, other programmers will see this commit and wonder what the explanation was. We should be able to concisely describe to people why we prefer this style.
Comment on attachment 68430 [details] Patch proposal Great description! Thanks.
Comment on attachment 68430 [details] Patch proposal Clearing flags on attachment: 68430 Committed r68111: <http://trac.webkit.org/changeset/68111>
All reviewed patches have been landed. Closing bug.