Bug 46271 - New review-page design doesn't include name of reviewer
Summary: New review-page design doesn't include name of reviewer
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-22 09:55 PDT by John Sullivan
Modified: 2010-09-22 21:20 PDT (History)
3 users (show)

See Also:


Attachments
Patch (1.86 KB, patch)
2010-09-22 21:12 PDT, Adam Barth
sullivan: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description John Sullivan 2010-09-22 09:55:09 PDT
Often I click a link to a bug review page that was sent in email (rather than following the link from the bug page itself). The first thing I do is check whether the patch has already been reviewed. If it has, I often want to know who supplied the r+ or r- for various reasons, one of them being that I am especially interested in reading comments from certain reviewers.

Unfortunately, the redesigned review-page has left this information out. I can scroll to the bottom to see whether or not the patch has been reviewed, but it doesn't display the name of the reviewer. Could this information be put back in there?
Comment 1 Adam Roben (:aroben) 2010-09-22 09:56:54 PDT
(In reply to comment #0)
> I often want to know who supplied the r+ or r- for various reasons, one of them being that I am especially interested in reading comments from certain reviewers.

If the reviewer left any comments, you'll see them inline with the patch. But I agree it would still be nice to see the names next to the r+/-.
Comment 2 Darin Adler 2010-09-22 09:57:13 PDT
I have noticed this many times in the past two days. Definitely worth fixing.
Comment 3 John Sullivan 2010-09-22 10:06:06 PDT
I had forgotten that reviewer comments have names, so the sample reason for wanting this that I provided doesn't apply. But I also want this for other reasons; for example, I have a higher confidence in some reviewers than others, so I might want to re-review or not, depending on who the original reviewer was.
Comment 4 Darin Adler 2010-09-22 10:12:31 PDT
I rarely remember to type “n” to see the reviewer comments. I just look at that plus and sit there wondering.
Comment 5 Adam Barth 2010-09-22 11:20:44 PDT
This is easy to add.
Comment 6 Adam Barth 2010-09-22 21:12:04 PDT
Created attachment 68498 [details]
Patch
Comment 7 John Sullivan 2010-09-22 21:14:52 PDT
Comment on attachment 68498 [details]
Patch

Thanks Adam!
Comment 8 Adam Barth 2010-09-22 21:20:03 PDT
Committed r68120: <http://trac.webkit.org/changeset/68120>