Bug 46266 – Would like a way to send patch review request e-mails with webkit-patch

• Status: NEW
• Component: Tools / Tests

[Anders Carlsson]

At Apple, we have an internal mailing list where we send patch review requests for bugzilla bugs. The mails are in the form:

> From: Anders Carlsson <[e-mail]>
> Subject: [PFR] Assertion fails in [WKView _updateWindowFrame] when closing a WebKit2 window
>
> https://bugs.webkit.org/attachment.cgi?id=68376&action=review
> https://bugs.webkit.org/show_bug.cgi?id=46264


It would be nice if webkit-patch had a feature where it could send an e-mail like this directly to a given e-mail address when posting a patch to bugzilla.

[Eric Seidel (no email)]

So this is rather straightforward to write.

Getting the bug links and title are as simple as calling self._tool.bugs.fetch_bug(bug_id) and accessing url(), title(), etc.

The Checkout() object can provide you information about the current checkout including the latest ChangeLogEntry which would include the bug_id().

One can send mail using http://docs.python.org/library/smtplib.html (configured to talk to Apple's SMTP) or just plain old self.tool.executive.run_command(["mail", "-s", subject, input=message) (if your machine is configured for smtp.

If this was written as a Step instead of a Command it could be added to the list of Steps that upload runs and guarded by a --send-mail option if desired.


Although I'm capable of writing the code, I'm not sure I fully understand the desired workflow.  It's not clear to me why the mailing list exists, for example?  Why not just CC the intended reviewers on the bug?

I guess the list is an artifact of the community being apple-internal?  Since there is a [e-mail] list which automatically gets review requests for the whole community.

Anyway, it's very possible to do this. But it may be better for me to explain to someone the technical details and let folks who do this workflow implement it exactly as would best fit for them.

[Eric Seidel (no email)]

We could write this as generic functionality and have it configurable by a git config option?  Maybe the Qt community has their own qt-reviews list they would like all qt contributors to post to when uploading a patch?