Bug 46244 - [GTK] Fix transfer annotations for WebKitGTK+ static API
Summary: [GTK] Fix transfer annotations for WebKitGTK+ static API
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-22 00:00 PDT by Xan Lopez
Modified: 2010-09-22 07:41 PDT (History)
0 users

See Also:


Attachments
annotations.diff (19.51 KB, patch)
2010-09-22 00:02 PDT, Xan Lopez
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Xan Lopez 2010-09-22 00:00:00 PDT
There's still a lot of warnings for the DOM bindings, and a bunch of warnings left here (mostly about the parameter being named differently in the comment and the function definition), but this fixes the bulk of them.
Comment 1 Xan Lopez 2010-09-22 00:02:03 PDT
Created attachment 68342 [details]
annotations.diff
Comment 2 Martin Robinson 2010-09-22 07:30:24 PDT
Comment on attachment 68342 [details]
annotations.diff

View in context: https://bugs.webkit.org/attachment.cgi?id=68342&action=review

Okay!

> WebKit/gtk/webkit/webkitwebdatasource.cpp:204
> + * not be freed or destroyed.  This will return %NULL of the

Could you please fix the typo before landing?

> WebKit/gtk/webkit/webkitwebview.cpp:3651
> + * Return value: (transfer none): the main #WebKitWebFrame for @webView, or %NULL

Might want to say what cases it returns NULL in.
Comment 3 Xan Lopez 2010-09-22 07:41:43 PDT
Comment on attachment 68342 [details]
annotations.diff

Landed as r68040 with the requested changes.
Comment 4 Xan Lopez 2010-09-22 07:41:53 PDT
Closing.