RESOLVED FIXED 46244
[GTK] Fix transfer annotations for WebKitGTK+ static API 
https://bugs.webkit.org/show_bug.cgi?id=46244
Summary [GTK] Fix transfer annotations for WebKitGTK+ static API
Xan Lopez
Reported 2010-09-22 00:00:00 PDT
There's still a lot of warnings for the DOM bindings, and a bunch of warnings left here (mostly about the parameter being named differently in the comment and the function definition), but this fixes the bulk of them.
Attachments
annotations.diff (19.51 KB, patch)
2010-09-22 00:02 PDT, Xan Lopez 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Xan Lopez
Comment 1 2010-09-22 00:02:03 PDT
Created attachment 68342 [details] annotations.diff
Martin Robinson
Comment 2 2010-09-22 07:30:24 PDT
Comment on attachment 68342 [details] annotations.diff View in context: https://bugs.webkit.org/attachment.cgi?id=68342&action=review Okay! > WebKit/gtk/webkit/webkitwebdatasource.cpp:204 > + * not be freed or destroyed. This will return %NULL of the Could you please fix the typo before landing? > WebKit/gtk/webkit/webkitwebview.cpp:3651 > + * Return value: (transfer none): the main #WebKitWebFrame for @webView, or %NULL Might want to say what cases it returns NULL in.
Xan Lopez
Comment 3 2010-09-22 07:41:43 PDT
Comment on attachment 68342 [details] annotations.diff Landed as r68040 with the requested changes.
Xan Lopez
Comment 4 2010-09-22 07:41:53 PDT
Closing.
Note You need to log in before you can comment on or make changes to this bug.