Bug 46229 – Need caps log and num lock state on Chromium input events

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit API

[Brett Wilson (Google)]

on WebInputEvents, we need to have the current caps lock and num lock state for some plugin messages.

[Brett Wilson (Google)]

Created attachment 68302 [details]
Patch for Linux & Windows

I'm not sure how to do this for Mac, I'm going to try to find a mac expert to do a patch for me in a later pass (will file a bug).

[WebKit Review Bot]

Attachment 68302 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/chromium/src/WebViewImpl.cpp:1089:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 1 in 6 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[Darin Fisher (:fishd, Google)]

Comment on attachment 68302 [details]
Patch for Linux & Windows

View in context: https://bugs.webkit.org/attachment.cgi?id=68302&action=review

> WebKit/chromium/public/WebInputEvent.h:127
> +        // WebCore, so round-tripping from  WebInputEvent to a WebCore

nit: only one space before WebInputEvent.

we also generally avoid mentioning WebCore types in WebKit API headers.
if the WebCore type name changes, then no one will ever update this
comment :-(  that said, i'm not sure how else to share this info.

> WebKit/chromium/src/WebViewImpl.h:321
> +    // cases where the WebKit input event doesn't have the information we need.

nit: WebKit input event -> WebCore DOM event?

[Brett Wilson (Google)]

Created attachment 68305 [details]
New patch

[Darin Fisher (:fishd, Google)]

Comment on attachment 68305 [details]
New patch

r=me

[Eric Seidel (no email)]

Did this get landed but not closed?  (If so, you might consider using webkit-patch land instead of svn commit, since it does all teh updating/closing, etc for you!)

[Eric Seidel (no email)]

r68047.  Please close bugs after landing or use a tool which does it for you (like webkit-patch land).