Bug 46229 - Need caps log and num lock state on Chromium input events
Summary: Need caps log and num lock state on Chromium input events
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit API (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Brett Wilson (Google)
Depends on:
Reported: 2010-09-21 16:23 PDT by Brett Wilson (Google)
Modified: 2010-12-20 22:53 PST (History)
2 users (show)

See Also:

Patch for Linux & Windows (6.55 KB, patch)
2010-09-21 16:25 PDT, Brett Wilson (Google)
no flags Details | Formatted Diff | Diff
New patch (6.54 KB, patch)
2010-09-21 16:38 PDT, Brett Wilson (Google)
fishd: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Brett Wilson (Google) 2010-09-21 16:23:45 PDT
on WebInputEvents, we need to have the current caps lock and num lock state for some plugin messages.
Comment 1 Brett Wilson (Google) 2010-09-21 16:25:57 PDT
Created attachment 68302 [details]
Patch for Linux & Windows

I'm not sure how to do this for Mac, I'm going to try to find a mac expert to do a patch for me in a later pass (will file a bug).
Comment 2 WebKit Review Bot 2010-09-21 16:28:55 PDT
Attachment 68302 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit/chromium/src/WebViewImpl.cpp:1089:  Use 0 instead of NULL.  [readability/null] [5]
Total errors found: 1 in 6 files

If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Darin Fisher (:fishd, Google) 2010-09-21 16:32:21 PDT
Comment on attachment 68302 [details]
Patch for Linux & Windows

View in context: https://bugs.webkit.org/attachment.cgi?id=68302&action=review

> WebKit/chromium/public/WebInputEvent.h:127
> +        // WebCore, so round-tripping from  WebInputEvent to a WebCore

nit: only one space before WebInputEvent.

we also generally avoid mentioning WebCore types in WebKit API headers.
if the WebCore type name changes, then no one will ever update this
comment :-(  that said, i'm not sure how else to share this info.

> WebKit/chromium/src/WebViewImpl.h:321
> +    // cases where the WebKit input event doesn't have the information we need.

nit: WebKit input event -> WebCore DOM event?
Comment 4 Brett Wilson (Google) 2010-09-21 16:38:25 PDT
Created attachment 68305 [details]
New patch
Comment 5 Darin Fisher (:fishd, Google) 2010-09-21 16:50:21 PDT
Comment on attachment 68305 [details]
New patch

Comment 6 Eric Seidel (no email) 2010-12-14 01:57:53 PST
Did this get landed but not closed?  (If so, you might consider using webkit-patch land instead of svn commit, since it does all teh updating/closing, etc for you!)
Comment 7 Eric Seidel (no email) 2010-12-20 22:53:51 PST
r68047.  Please close bugs after landing or use a tool which does it for you (like webkit-patch land).