Bug 46226 - -[WebView _scheduleCompositingLayerSync] should wake the run loop
Summary: -[WebView _scheduleCompositingLayerSync] should wake the run loop
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Layout and Rendering (show other bugs)
Version: 528+ (Nightly build)
Hardware: Mac OS X 10.6
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-21 16:00 PDT by Paul Knight
Modified: 2010-09-22 01:37 PDT (History)
2 users (show)

See Also:

Attachments
suggested patch (1.58 KB, patch)
2010-09-21 16:34 PDT, Paul Knight 		simon.fraser: review+
Details | Formatted Diff | Diff
Address feedback from Simon Fraser, add a period at the end of a comment. (1.58 KB, patch)
2010-09-21 16:42 PDT, Paul Knight 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Paul Knight 2010-09-21 16:00:31 PDT 
This is in Radar as <rdar://problem/8460238>.

-[WebView _scheduleCompositingLayerSync] should ensure that the runloop is woken up if the RLO is already scheduled. Otherwise, layers might not get synced for a while until some other event wakes the run loop, causing rendering delays.
Comment 1 Paul Knight 2010-09-21 16:34:46 PDT 
Created attachment 68304 [details]
suggested patch
Comment 2 Simon Fraser (smfr) 2010-09-21 16:38:32 PDT 
Comment on attachment 68304 [details]
suggested patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68304&action=review

> WebKit/mac/WebView/WebView.mm:5874
> +    // Make sure we wake up the loop or the observer could be delayed until some other source fires

Period at the end of the sentence please.
Comment 3 Paul Knight 2010-09-21 16:42:33 PDT 
Created attachment 68306 [details]
Address feedback from Simon Fraser, add a period at the end of a comment.
Comment 4 WebKit Commit Bot 2010-09-22 01:37:10 PDT 
Comment on attachment 68306 [details]
Address feedback from Simon Fraser, add a period at the end of a comment.

Clearing flags on attachment: 68306

Committed r68028: <http://trac.webkit.org/changeset/68028>
Comment 5 WebKit Commit Bot 2010-09-22 01:37:15 PDT 
All reviewed patches have been landed.  Closing bug.