RESOLVED FIXED 46216
[GTK] The FreeType backend does not respect the FC_EMBOLDEN property 
https://bugs.webkit.org/show_bug.cgi?id=46216
Summary [GTK] The FreeType backend does not respect the FC_EMBOLDEN property
Martin Robinson
Reported Tuesday, September 21, 2010 10:13:24 PM UTC
The FC_EMBOLDEN property is used by FontConfig to enable synthetic bold during rendering. We do not look at this property at all.
Attachments
Patch for this issue (6.46 KB, patch)
2010-09-21 14:26 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Fix my broken commit (2.85 KB, patch)
2010-10-07 14:15 PDT, Martin Robinson 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Martin Robinson
Comment 1 Tuesday, September 21, 2010 10:26:56 PM UTC
Created attachment 68292 [details] Patch for this issue
chris fleizach
Comment 2 Tuesday, September 21, 2010 11:16:49 PM UTC
Comment on attachment 68292 [details] Patch for this issue r=me
Martin Robinson
Comment 3 Wednesday, September 22, 2010 1:03:25 AM UTC
Thanks for the review! I should be able to land this once the patches on the blockers are reviewed.
Martin Robinson
Comment 4 Thursday, October 7, 2010 7:40:01 PM UTC
Committed r69326: <http://trac.webkit.org/changeset/69326>
Martin Robinson
Comment 5 Thursday, October 7, 2010 10:15:14 PM UTC
Created attachment 70149 [details] Fix my broken commit
Martin Robinson
Comment 6 Thursday, October 7, 2010 10:15:53 PM UTC
This commit was landed in a broken state. I've posted a patch which fixes this.
Gustavo Noronha (kov)
Comment 7 Thursday, October 7, 2010 10:22:30 PM UTC
Comment on attachment 70149 [details] Fix my broken commit Sure!
Martin Robinson
Comment 8 Friday, October 8, 2010 12:57:50 AM UTC
Comment on attachment 70149 [details] Fix my broken commit Clearing flags on attachment: 70149 Committed r69355: <http://trac.webkit.org/changeset/69355>
Martin Robinson
Comment 9 Friday, October 8, 2010 12:57:54 AM UTC
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 10 Friday, October 8, 2010 2:11:30 AM UTC
http://trac.webkit.org/changeset/69355 might have broken GTK Linux 32-bit Release
Tony Chang
Comment 11 Friday, May 6, 2011 6:27:58 PM UTC
platform/gtk/fonts/fontconfig-synthetic-bold.html is missing a pixel test result. Can you add one?
Martin Robinson
Comment 12 Monday, May 9, 2011 6:52:14 PM UTC
Sure thing. Added in http://trac.webkit.org/changeset/86065.
Note You need to log in before you can comment on or make changes to this bug.