Bug 46206 – [WINCE] Remove usage of MemoryManager

• Status: RESOLVED
• Resolution: FIXED
• Component: Platform

[Patrick R. Gansterer]

see patch

[Patrick R. Gansterer]

Created attachment 68269 [details]
Patch

[chris fleizach]

Comment on attachment 68269 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68269&action=review

> WebCore/ChangeLog:9
> +

can you explain why someone thought it provided value before, and what is the benefit of changing

> WebCore/platform/graphics/wince/PlatformPathWinCE.cpp:-237
> -    MemoryAllocationCanFail canFail;

why does this need to be removed. is this part of the MemoryManager change?

[Patrick R. Gansterer]

(In reply to comment #2)
> (From update of attachment 68269 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=68269&action=review
> 
> > WebCore/ChangeLog:9
> > +
> 
> can you explain why someone thought it provided value before, and what is the benefit of changing
No, sorry, the initial bug 27550 does not say anything. :(

> 
> > WebCore/platform/graphics/wince/PlatformPathWinCE.cpp:-237
> > -    MemoryAllocationCanFail canFail;
> 
> why does this need to be removed. is this part of the MemoryManager change?
MemoryAllocationCanFail is part of the MemoryManager. (see http://trac.webkit.org/browser/trunk/JavaScriptCore/wtf/wince/MemoryManager.h?rev=46268#L60)

[Adam Roben (:aroben)]

Comment on attachment 68269 [details]
Patch

I think Patrick answered Chris's questions satisfactorily. Chris, if you feel otherwise please let me know!

[WebKit Commit Bot]

Comment on attachment 68269 [details]
Patch

Clearing flags on attachment: 68269

Committed r68135: <http://trac.webkit.org/changeset/68135>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.