WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 46205
cleanup: removeInlineStyleFromElement and extractInlineStyleToPushDown should be merged
https://bugs.webkit.org/show_bug.cgi?id=46205
Summary
cleanup: removeInlineStyleFromElement and extractInlineStyleToPushDown should...
Ryosuke Niwa
Reported
2010-09-21 11:40:14 PDT
Since removeImplicitlyStyledElement already supports extraction of the existing style, we should extend the support to removeInlineStyleFromElement and removeCSSStyle so that extractInlineStyleToPushDown can be merged with removeInlineStyleFromElement.
Attachments
Patch
(10.11 KB, patch)
2010-09-21 11:51 PDT
,
Ryosuke Niwa
tkent
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Ryosuke Niwa
Comment 1
2010-09-21 11:51:46 PDT
Created
attachment 68268
[details]
Patch
Kent Tamura
Comment 2
2010-09-21 18:59:39 PDT
Comment on
attachment 68268
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=68268&action=review
> WebCore/ChangeLog:12 > + (WebCore::ApplyStyleCommand::removeInlineStyleFromElement): Added extractedStyle.
nit: extractedStyle -> extractedStyle parameter or extractedStyle argument
> WebCore/ChangeLog:13 > + (WebCore::ApplyStyleCommand::removeCSSStyle): Added extractedStyle.
ditto.
Ryosuke Niwa
Comment 3
2010-09-21 22:36:57 PDT
Committed
r68014
: <
http://trac.webkit.org/changeset/68014
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug