Bug 46199 - [chromium] LayerRendererChromium::prepareToDrawLayers logic needs cleanup
Summary: [chromium] LayerRendererChromium::prepareToDrawLayers logic needs cleanup
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebCore Misc. (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Vangelis Kokkevis
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-21 10:26 PDT by Vangelis Kokkevis
Modified: 2010-09-21 13:53 PDT (History)
5 users (show)

See Also:


Attachments
proposed patch (5.11 KB, patch)
2010-09-21 12:10 PDT, Vangelis Kokkevis
no flags Details | Formatted Diff | Diff
proposed patch - fixed some comments (5.13 KB, patch)
2010-09-21 12:20 PDT, Vangelis Kokkevis
jamesr: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Vangelis Kokkevis 2010-09-21 10:26:10 PDT
There are a couple of issues here:
1. When the window size changes the entire root layer texture must be updated.  There's no reason to perform scrolling operations there.
2. When the scroll offset is larger than the size of the page we shouldn't be doing the glCopyPixels as there's no useful pixels to copy from
3. It shouldn't call updateLayersRecursive as that method is actually called right before the layers are drawn in the drawLayers() method.
Comment 1 Vangelis Kokkevis 2010-09-21 12:10:01 PDT
Created attachment 68272 [details]
proposed patch
Comment 2 Vangelis Kokkevis 2010-09-21 12:20:18 PDT
Created attachment 68274 [details]
proposed patch - fixed some comments
Comment 3 James Robinson 2010-09-21 12:40:09 PDT
Comment on attachment 68274 [details]
proposed patch - fixed some comments

Looks good
Comment 4 Vangelis Kokkevis 2010-09-21 12:49:18 PDT
Committed r67977: <http://trac.webkit.org/changeset/67977>