WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
46196
Add marginBefore/After/Start/End accessors to RenderBoxModelObject and subclasses
https://bugs.webkit.org/show_bug.cgi?id=46196
Summary
Add marginBefore/After/Start/End accessors to RenderBoxModelObject and subcla...
Dave Hyatt
Reported
2010-09-21 09:55:12 PDT
Add marginBefore/After/Start/End accessors to RenderBoxModelObject and subclasses.
Attachments
Patch
(7.56 KB, patch)
2010-09-21 09:59 PDT
,
Dave Hyatt
no flags
Details
Formatted Diff
Diff
Patch
(7.56 KB, patch)
2010-09-21 10:01 PDT
,
Dave Hyatt
mitz: review+
Details
Formatted Diff
Diff
Show Obsolete
(1)
View All
Add attachment
proposed patch, testcase, etc.
Dave Hyatt
Comment 1
2010-09-21 09:59:58 PDT
Created
attachment 68252
[details]
Patch
Dave Hyatt
Comment 2
2010-09-21 10:01:25 PDT
Created
attachment 68253
[details]
Patch
mitz
Comment 3
2010-09-21 10:05:04 PDT
Comment on
attachment 68253
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=68253&action=review
> WebCore/rendering/RenderInline.h:44 > + virtual int marginTop() const; > + virtual int marginBottom() const;
Any reason why these need to be public now (or, for that matter, any of the new methods)?
Dave Hyatt
Comment 4
2010-09-21 10:49:38 PDT
Fixed in
r67964
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug