The borderStart/End/Before/After methods are hardcoded to a specific block flow directionality for collapsed border tables.
Created attachment 72838 [details] Patch
Comment on attachment 72838 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=72838&action=review r=me > WebCore/rendering/RenderTableCell.cpp:666 > +CollapsedBorderValue RenderTableCell::collapsedLeftBorder() const > +{ > + if (table()->style()->isHorizontalWritingMode()) > + return table()->style()->isLeftToRightDirection() ? collapsedStartBorder() : collapsedEndBorder(); > + return table()->style()->isFlippedBlocksWritingMode() ? collapsedAfterBorder() : collapsedBeforeBorder(); I would cache table()->style() in a local and then use it in the three places where you acccess it. Ditto for collapsedRight/Top/BottomBorder. > WebCore/rendering/RenderTableCell.cpp:743 > +int RenderTableCell::borderHalfRight(bool outer) const > +{ > + if (table()->style()->isHorizontalWritingMode()) > + return table()->style()->isLeftToRightDirection() ? borderHalfEnd(outer) : borderHalfStart(outer); > + return table()->style()->isFlippedBlocksWritingMode() ? borderHalfBefore(outer) : borderHalfAfter(outer); Same comment. Cache table()->style() in a local. Same for all of the borderHalf*** functions.
Landed as <http://trac.webkit.org/projects/webkit/changeset/71251>.