Bug 46188 - Make the cross-platform setPrinting method match the Mac-specific WebKit method.
Summary: Make the cross-platform setPrinting method match the Mac-specific WebKit method.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Printing (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-21 08:52 PDT by Dave Hyatt
Modified: 2010-09-21 08:58 PDT (History)
0 users

See Also:

Attachments
Patch (1.43 KB, patch)
2010-09-21 08:54 PDT, Dave Hyatt 		sullivan: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-09-21 08:52:53 PDT 
OS X does not use Frame::setPrinting, since it still has its own WebKit method.  The cross-platform method was copied from it, and I noticed while mucking around in the printing code that it contains an error.  Subframes are not supposed to receive the page size or lay out to the page size.  The Mac method just passes 0 for all the numbers to child frames, so I will change the cross-platform method to match.
Comment 1 Dave Hyatt 2010-09-21 08:54:38 PDT 
Created attachment 68244 [details]
Patch
Comment 2 Dave Hyatt 2010-09-21 08:58:37 PDT 
Fixed in r67956.