RESOLVED FIXED 46185
[WIN] Add internetHandle to WebCoreSynchronousLoader. 
https://bugs.webkit.org/show_bug.cgi?id=46185
Summary [WIN] Add internetHandle to WebCoreSynchronousLoader.
Patrick R. Gansterer
Reported 2010-09-21 07:21:24 PDT
see patch
Attachments
Patch (3.46 KB, patch)
2010-09-21 07:23 PDT, Patrick R. Gansterer 		aroben: review+
aroben: commit-queue-
DetailsFormatted DiffDiff
Patch (3.34 KB, patch)
2010-09-21 09:03 PDT, Patrick R. Gansterer 		no flags
DetailsFormatted DiffDiff
Show Obsolete (1) View All Add attachment proposed patch, testcase, etc.
Patrick R. Gansterer
Comment 1 2010-09-21 07:23:25 PDT
Created attachment 68237 [details] Patch
Adam Roben (:aroben)
Comment 2 2010-09-21 07:54:48 PDT
Comment on attachment 68237 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68237&action=review > WebCore/platform/network/win/ResourceHandleWin.cpp:87 > +static HINTERNET asynchronousInternetHandle(const String& userAgent) > +{ > + static HINTERNET internetHandle = 0; > + > + if (!internetHandle) > + internetHandle = createInternetHandle(userAgent, true); > + > + return internetHandle; > +} You can do this more simply: static HINTERNET internetHandle = createInternetHandle(userAgent, true); return internetHandle; > WebCore/platform/network/win/ResourceHandleWin.cpp:188 > , m_response(response) > , m_data(data) > { > + m_internetHandle = createInternetHandle(userAgent, false); > +} Why not put this in the initializer list?
Patrick R. Gansterer
Comment 3 2010-09-21 09:03:00 PDT
Created attachment 68245 [details] Patch
WebKit Commit Bot
Comment 4 2010-09-22 00:37:30 PDT
Comment on attachment 68245 [details] Patch Clearing flags on attachment: 68245 Committed r68020: <http://trac.webkit.org/changeset/68020>
WebKit Commit Bot
Comment 5 2010-09-22 00:37:35 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.