Bug 46178 - it's not possible to easily tell which part of the file name of an indexed db is the security origin
Summary: it's not possible to easily tell which part of the file name of an indexed db...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: jochen
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-21 04:56 PDT by jochen
Modified: 2010-09-21 07:20 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.56 KB, patch)
2010-09-21 05:00 PDT, jochen 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description jochen 2010-09-21 04:56:41 PDT 
it's not possible to easily tell which part of the file name of an indexed db is the security origin
Comment 1 jochen 2010-09-21 05:00:04 PDT 
Created attachment 68221 [details]
Patch
Comment 2 Jeremy Orlow 2010-09-21 05:21:07 PDT 
Comment on attachment 68221 [details]
Patch

r=me
Comment 3 Jeremy Orlow 2010-09-21 05:24:37 PDT 
NOTE: this will cause a bunch of dead db files to stay around.  Those could possibly cause parsing issues if we use securityOrigin::fromDatabaseIdentifier on these file names or something like that.  It might be best for all indexed db developers to delete their indexedDB directory from chromium after syncing all clients past this.  Otherwise it's quite possible you'll run into some odd/nasty errors in the future if any code does make assumptions about all the files in this dir.

The other option is to, after this lands, change the directory we save IndexedDB stuff in...but I don't think that's necessary.

Also, obviously any existing data in databases with the old name format will no longer be accessible...but I doubt anyone cares.
Comment 4 WebKit Commit Bot 2010-09-21 07:20:01 PDT 
Comment on attachment 68221 [details]
Patch

Clearing flags on attachment: 68221

Committed r67950: <http://trac.webkit.org/changeset/67950>
Comment 5 WebKit Commit Bot 2010-09-21 07:20:06 PDT 
All reviewed patches have been landed.  Closing bug.