Bug 46177 – Make FilterEffects independent of SVG

• Status: RESOLVED
• Resolution: FIXED
• Component: SVG

[Dirk Schulze]

Make FilterEffects independent of SVG

[Dirk Schulze]

Created attachment 68220 [details]
Patch

[Dirk Schulze]

(In reply to comment #1)
> Created an attachment (id=68220) [details]
> Patch

Just Mac is missing, since I can't update Xcode from here.

[Nikolas Zimmermann]

(In reply to comment #2)
> (In reply to comment #1)
> > Created an attachment (id=68220) [details] [details]
> > Patch
> 
> Just Mac is missing, since I can't update Xcode from here.

Isn't it possible to manually move them, by just editing the file?;
The UUID stays the same, you should just have to reorder them.

[Early Warning System Bot]

Attachment 68220 [details] did not build on qt:
Build output: http://queues.webkit.org/results/3999077

[Dirk Schulze]

Created attachment 68222 [details]
Patch

[Eric Seidel (no email)]

Attachment 68220 [details] did not build on mac:
Build output: http://queues.webkit.org/results/4049096

[Dirk Schulze]

Created attachment 68224 [details]
Patch

[Dirk Schulze]

(In reply to comment #3)
> (In reply to comment #2)
> > (In reply to comment #1)
> > > Created an attachment (id=68220) [details] [details] [details]
> > > Patch
> > 
> > Just Mac is missing, since I can't update Xcode from here.
> 
> Isn't it possible to manually move them, by just editing the file?;
> The UUID stays the same, you should just have to reorder them.

Tried it with the last patch. Let's see if I got it to work.

[Eric Seidel (no email)]

Attachment 68222 [details] did not build on mac:
Build output: http://queues.webkit.org/results/4026090

[Eric Seidel (no email)]

Attachment 68224 [details] did not build on mac:
Build output: http://queues.webkit.org/results/4098015

[Dirk Schulze]

Created attachment 68239 [details]
Patch

[Dirk Schulze]

Modified the project file with Xcode this time. Hopefully it builds now. Didn't test it on my local machine.

[Dirk Schulze]

Not sure why the ews bot for win has problems. I updated to trunk and had no problems applying this patch.

[Dirk Schulze]

Uploading the same patch again to restart Win EWS.

[Dirk Schulze]

Created attachment 68341 [details]
Patch

[Nikolas Zimmermann]

Comment on attachment 68341 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68341&action=review

> WebCore/ChangeLog:16
> +        * WebCore.vcproj/WebCore.vcproj:

WebCore.xcodeproj not listed here.

Even if we don't know if win builds, EWS is taking just too long. Just try landing.

[Dirk Schulze]

Committed r68022: <http://trac.webkit.org/changeset/68022>

[Dirk Schulze]

Comment on attachment 68341 [details]
Patch

Already committed. Clearing r-flag.