Bug 46172 - [Qt] Add robot loader timeout and extra time options.
Summary: [Qt] Add robot loader timeout and extra time options.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Enhancement
Assignee: Jocelyn Turcotte
URL:
Keywords: Qt
Depends on:
Blocks:
 
Reported: 2010-09-21 03:37 PDT by Jocelyn Turcotte
Modified: 2010-09-21 10:31 PDT (History)
1 user (show)

See Also:


Attachments
Patch (6.90 KB, patch)
2010-09-21 03:41 PDT, Jocelyn Turcotte
akling: review+
akling: commit-queue-
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Jocelyn Turcotte 2010-09-21 03:37:06 PDT
[Qt] Add robot loader timeout and extra time options.
Comment 1 Jocelyn Turcotte 2010-09-21 03:41:54 PDT
Created attachment 68208 [details]
Patch
Comment 2 Jocelyn Turcotte 2010-09-21 03:44:23 PDT
These options are used to run stability tests on Symbian using QtTestBrowser.

Right now the robot loader relies on the loadFinished signal to continue loading the URL list, however we have some load hangs on that platform that prevent us testing further to catch long term usage crashes.
Comment 3 Andreas Kling 2010-09-21 04:00:49 PDT
Comment on attachment 68208 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68208&action=review

> WebKitTools/QtTestBrowser/urlloader.cpp:50
> +    } else {

Coding style, should be "} else"

r=me
Comment 4 Jocelyn Turcotte 2010-09-21 07:34:57 PDT
Committed r67942: <http://trac.webkit.org/changeset/67942>
Comment 5 Ademar Reis 2010-09-21 10:30:55 PDT
Revision r67942 cherry-picked into qtwebkit-2.1 with commit a47890e <http://gitorious.org/webkit/qtwebkit/commit/a47890e>