Bug 46168 - [reviewtool] Publish button doesn't work
Summary: [reviewtool] Publish button doesn't work
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-21 00:53 PDT by Adam Barth
Modified: 2010-09-21 09:26 PDT (History)
1 user (show)

See Also:


Attachments
Patch (995 bytes, patch)
2010-09-21 00:55 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-09-21 00:53:29 PDT
[reviewtool] Publish button doesn't work
Comment 1 Adam Barth 2010-09-21 00:55:12 PDT
Created attachment 68199 [details]
Patch
Comment 2 Adam Barth 2010-09-21 01:02:30 PDT
Committed r67931: <http://trac.webkit.org/changeset/67931>
Comment 3 Adam Barth 2010-09-21 01:05:39 PDT
Comment on attachment 68199 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68199&action=review

> BugsSite/code-review.js:478
> -    review_form.find('form').submit();
> +    $('#reviewform').contents().find('form').submit();

test
Comment 4 Darin Adler 2010-09-21 09:26:25 PDT
Thanks for fixing that. Sorry I wasn’t around when the patch landed!