WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
46168
[reviewtool] Publish button doesn't work
https://bugs.webkit.org/show_bug.cgi?id=46168
Summary
[reviewtool] Publish button doesn't work
Adam Barth
Reported
2010-09-21 00:53:29 PDT
[reviewtool] Publish button doesn't work
Attachments
Patch
(995 bytes, patch)
2010-09-21 00:55 PDT
,
Adam Barth
no flags
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Adam Barth
Comment 1
2010-09-21 00:55:12 PDT
Created
attachment 68199
[details]
Patch
Adam Barth
Comment 2
2010-09-21 01:02:30 PDT
Committed
r67931
: <
http://trac.webkit.org/changeset/67931
>
Adam Barth
Comment 3
2010-09-21 01:05:39 PDT
Comment on
attachment 68199
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=68199&action=review
> BugsSite/code-review.js:478 > - review_form.find('form').submit(); > + $('#reviewform').contents().find('form').submit();
test
Darin Adler
Comment 4
2010-09-21 09:26:25 PDT
Thanks for fixing that. Sorry I wasn’t around when the patch landed!
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug