Bug 46160 - The tool member variable should be called _tool
Summary: The tool member variable should be called _tool
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-20 20:06 PDT by Adam Barth
Modified: 2010-09-20 21:00 PDT (History)
4 users (show)

See Also:

Attachments
Patch (24.52 KB, patch)
2010-09-20 20:07 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-09-20 20:06:21 PDT 
The tool member variable should be called _tool
Comment 1 Adam Barth 2010-09-20 20:07:24 PDT 
Created attachment 68180 [details]
Patch
Comment 2 WebKit Review Bot 2010-09-20 20:09:18 PDT 
Attachment 68180 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/Scripts/webkitpy/tool/multicommandtool.py:192:  at least two spaces before inline comment  [pep8/E261] [5]
Total errors found: 1 in 10 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 WebKit Commit Bot 2010-09-20 20:24:26 PDT 
Comment on attachment 68180 [details]
Patch

Clearing flags on attachment: 68180

Committed r67916: <http://trac.webkit.org/changeset/67916>
Comment 4 WebKit Commit Bot 2010-09-20 20:24:31 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Review Bot 2010-09-20 21:00:37 PDT 
http://trac.webkit.org/changeset/67916 might have broken SnowLeopard Intel Release (Tests)