Currently LayerChromium doesn't define it destructor as virtual which means that destructors for derived types don't execute when layers get removed from the layer tree.
Created attachment 68170 [details] proposed patch
Comment on attachment 68170 [details] proposed patch R=me Technically the virtual keyword on ContentLayerChromium is redundant, but I prefer to have it for clarity.
Committed r67906: <http://trac.webkit.org/changeset/67906>
Reverted r67906 for reason: Change causes chromium to crash when switching pages Committed r67912: <http://trac.webkit.org/changeset/67912>
Created attachment 68973 [details] Proposed patch - Does proper ref counting for the compositor Corrected the reason why the previous patch was causing crashes which was that LayerChromium destructors could end up getting called after the layer compositor and its associated gl context were destroyed. This patch makes the LayerRendererChromium a ref counted class and the LayerChromium's used by it are now holding a reference to LayerRendererChromium they are used with. This ensures that the gl context used by the layers will outlive the layers themselves.
Attachment 68973 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebCore/platform/graphics/chromium/ContentLayerChromium.cpp:138: One line control clauses should not use braces. [whitespace/braces] [4] Total errors found: 1 in 9 files If any of these errors are false positives, please file a bug against check-webkit-style.
Created attachment 68975 [details] proposed patch - fixed style issue
Comment on attachment 68975 [details] proposed patch - fixed style issue Looks good!
Committed r68442: <http://trac.webkit.org/changeset/68442>
http://trac.webkit.org/changeset/68442 might have broken Leopard Intel Release (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/68441 http://trac.webkit.org/changeset/68442 http://trac.webkit.org/changeset/68443 http://trac.webkit.org/changeset/68444 http://trac.webkit.org/changeset/68445