Bug 46122 - Check endianness with __BIG_ENDIAN in RVCT.
Summary: Check endianness with __BIG_ENDIAN in RVCT.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Web Template Framework (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-20 14:45 PDT by Kwang Yul Seo
Modified: 2010-10-24 21:39 PDT (History)
4 users (show)

See Also:

Attachments
Patch (1.02 KB, patch)
2010-09-20 14:46 PDT, Kwang Yul Seo 		ddkilzer: review-
ddkilzer: commit-queue-
Details | Formatted Diff | Diff
Patch (1.02 KB, patch)
2010-10-24 20:14 PDT, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-09-20 14:45:10 PDT 
RVCT defines __BIG_ENDIAN if compiling for a big-endian target.
Comment 1 Kwang Yul Seo 2010-09-20 14:46:40 PDT 
Created attachment 68140 [details]
Patch
Comment 2 Kwang Yul Seo 2010-09-20 14:49:30 PDT 
CC'ing Laszlo for review.
Comment 3 Kwang Yul Seo 2010-10-01 09:47:44 PDT 
CC'ing Gabor
Comment 4 David Kilzer (:ddkilzer) 2010-10-24 08:49:38 PDT 
Comment on attachment 68140 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68140&action=review

r- to update the test

> JavaScriptCore/wtf/Platform.h:213
> +#if defined(__ARMEB__) || defined(__BIG_ENDIAN) /* RVCT defines __BIG_ENDIAN */

Please use this instead since it's self-documenting:

    #if deined(__ARMEB__) || COMPILER(RVCT) && defined(__BIG_ENDIAN)
Comment 5 Kwang Yul Seo 2010-10-24 20:14:12 PDT 
Created attachment 71710 [details]
Patch

Check COMPILER(RVCT) && defined(__BIG_ENDIAN)
Comment 6 David Kilzer (:ddkilzer) 2010-10-24 20:47:38 PDT 
Comment on attachment 71710 [details]
Patch

Thanks!  r=me
Comment 7 WebKit Commit Bot 2010-10-24 21:39:27 PDT 
Comment on attachment 71710 [details]
Patch

Clearing flags on attachment: 71710

Committed r70434: <http://trac.webkit.org/changeset/70434>
Comment 8 WebKit Commit Bot 2010-10-24 21:39:33 PDT 
All reviewed patches have been landed.  Closing bug.