WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
46119
Add logical accessors to RenderStyle for margins, padding, border widths, widths and heights.
https://bugs.webkit.org/show_bug.cgi?id=46119
Summary
Add logical accessors to RenderStyle for margins, padding, border widths, wid...
Dave Hyatt
Reported
2010-09-20 14:05:11 PDT
Need to add logical accessors to RenderStyle so layout code can switch over to logical terms like before/after/start/end instead of top/bottom/left/right.
Attachments
Patch
(8.86 KB, patch)
2010-09-20 14:26 PDT
,
Dave Hyatt
mitz: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Dave Hyatt
Comment 1
2010-09-20 14:26:24 PDT
Created
attachment 68136
[details]
Patch
mitz
Comment 2
2010-09-20 14:30:15 PDT
Comment on
attachment 68136
[details]
Patch View in context:
https://bugs.webkit.org/attachment.cgi?id=68136&action=review
> WebCore/rendering/style/RenderStyle.cpp:1118 > + default:
Please change these default:s to case RightToLeftBlockFlow:
Dave Hyatt
Comment 3
2010-09-20 14:35:26 PDT
Fixed in
r67884
.
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug