Bug 46119 - Add logical accessors to RenderStyle for margins, padding, border widths, widths and heights.
Summary: Add logical accessors to RenderStyle for margins, padding, border widths, wid...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-20 14:05 PDT by Dave Hyatt
Modified: 2010-09-20 14:35 PDT (History)
0 users

See Also:

Attachments
Patch (8.86 KB, patch)
2010-09-20 14:26 PDT, Dave Hyatt 		mitz: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-09-20 14:05:11 PDT 
Need to add logical accessors to RenderStyle so layout code can switch over to logical terms like before/after/start/end instead of top/bottom/left/right.
Comment 1 Dave Hyatt 2010-09-20 14:26:24 PDT 
Created attachment 68136 [details]
Patch
Comment 2 mitz 2010-09-20 14:30:15 PDT 
Comment on attachment 68136 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68136&action=review

> WebCore/rendering/style/RenderStyle.cpp:1118
> +    default:

Please change these default:s to case RightToLeftBlockFlow:
Comment 3 Dave Hyatt 2010-09-20 14:35:26 PDT 
Fixed in r67884.