Bug 46118 – Switch Chromium bots to build and test, one set in release, one set in debug.

• Status: RESOLVED
• Resolution: INVALID
• Component: New Bugs

[Dimitri Glazkov (Google)]

Switch Chromium bots to build and test, one set in release, one set in debug.

[Dimitri Glazkov (Google)]

Created attachment 68131 [details]
Patch

[Dimitri Glazkov (Google)]

It seems that we no longer need just the builders. Build-and-test cycles are stable enough to start using them everywhere and debug builds are very useful.

[Ojan Vafai]

Comment on attachment 68131 [details]
Patch

If this is the fastest way to getting debug bots up, then this seems fine to me. What we lose with this patch is:
-Cycle time goes up and we get less fine granularity for regressions
-The bots are frequently red, so they'd probably be removed from the core waterfall. Right now, when the Chrome compile breaks, it gets noticed because it's on the core waterfall.

[Adam Barth]

Comment on attachment 68131 [details]
Patch

One detail: this will knock the chromium builders out of set of core builders since the tests builders don't (yet) stay green.

[Dimitri Glazkov (Google)]

(In reply to comment #4)
> (From update of attachment 68131 [details])
> One detail: this will knock the chromium builders out of set of core builders since the tests builders don't (yet) stay green.

I will make sure that webkitpy/webkitperl tests are green (or not running) prior to switching. Other than that, the redness in layout tests is the same as what you would see on the canaries.

[Adam Barth]

>> One detail: this will knock the chromium builders out of set of core builders since the tests builders don't (yet) stay green.
> 
> I will make sure that webkitpy/webkitperl tests are green (or not running) prior to switching. Other than that, the redness in layout tests is the same as what you would see on the canaries.

That's really the issue.  As long as the entire bot is usually red, the bot wouldn't be part of the core builders.  Before, the Chromium builders were part of the core builders because compilation was reliably green.

[Dimitri Glazkov (Google)]

(In reply to comment #6)
> >> One detail: this will knock the chromium builders out of set of core builders since the tests builders don't (yet) stay green.
> > 
> > I will make sure that webkitpy/webkitperl tests are green (or not running) prior to switching. Other than that, the redness in layout tests is the same as what you would see on the canaries.
> 
> That's really the issue.  As long as the entire bot is usually red, the bot wouldn't be part of the core builders.  Before, the Chromium builders were part of the core builders because compilation was reliably green.

I don't understand. If someone breaks the layout tests on Chromium, shouldn't they just fix it?

[Adam Barth]

> I don't understand. If someone breaks the layout tests on Chromium, shouldn't they just fix it?

Dunno.  Sampling the bots right now, Chromium Win Release (Tests) has an SVN exception and Chromium Mac Release (Tests) is failing a bunch of tests.  Hopefully in the future they will be consistently green and can then be added to the core builders.

My point is you're trading some green bots (the compile-only bots) for bots that are likely to be red much of the time, at least for a while.  That's probably the right thing to do, but I want to make sure you're aware of this subtle issue.

[Dimitri Glazkov (Google)]

(In reply to comment #8)
> > I don't understand. If someone breaks the layout tests on Chromium, shouldn't they just fix it?
> 
> Dunno.  Sampling the bots right now, Chromium Win Release (Tests) has an SVN exception and Chromium Mac Release (Tests) is failing a bunch of tests.  Hopefully in the future they will be consistently green and can then be added to the core builders.
> 
> My point is you're trading some green bots (the compile-only bots) for bots that are likely to be red much of the time, at least for a while.  That's probably the right thing to do, but I want to make sure you're aware of this subtle issue.

You're right. We need to make an effort to make these more reliable and improve tooling to enable greenness. But in a way, until they are core builders, there won't be much attention paid to them. Commence vicious cycle.

[Adam Barth]

> Commence vicious cycle.

I like to think the reverse is a virtuous cycle.  :)

[Eric Seidel (no email)]

Was this landed and just not closed?

[Dimitri Glazkov (Google)]

No, we probably need to a different thing here anyhow.