Bug 46117 – Add a way to delay sending replies to sync requests

• Status: RESOLVED
• Resolution: FIXED
• Component: WebKit2

[Anders Carlsson]

Add a way to delay sending replies to sync requests

[Anders Carlsson]

Created attachment 68129 [details]
Patch

[Adam Roben (:aroben)]

Comment on attachment 68129 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68129&action=review

> WebKit2/Platform/CoreIPC/Connection.cpp:276
> -            OwnPtr<ArgumentEncoder> replyEncoder(new ArgumentEncoder(syncRequestID));
> +            ArgumentEncoder* replyEncoder = new ArgumentEncoder(syncRequestID);
>              
>              // Hand off both the decoder and encoder to the client..
> -            m_client->didReceiveSyncMessage(this, message.messageID(), arguments.get(), replyEncoder.get());
> +            SyncReplyMode syncReplyMode = m_client->didReceiveSyncMessage(this, message.messageID(), arguments.get(), replyEncoder);
>              
>              // FIXME: If the message was invalid, we should send back a SyncMessageError.
>              ASSERT(!arguments->isInvalid());
>  
> -            // Send the reply.
> -            sendMessage(MessageID(CoreIPCMessage::SyncMessageReply), replyEncoder.release());
> +            if (syncReplyMode == AutomaticReply) {
> +                // Send the reply.
> +                sendSyncReply(replyEncoder);
> +            } else {
> +                // The client will take ownership of the reply encoder and send it at some point in the future.
> +                // We won't do anything here.
> +            }

Another option is to continue to use OwnPtr, and then call leakPtr in the ManualReply case. Yet another option is to use a bare pointer, but wrap the call to new in adoptPtr/leakPtr.

[Anders Carlsson]

Committed r67891: <http://trac.webkit.org/changeset/67891>