Bug 46116 - Implement block-flow-aware logical properties
Summary: Implement block-flow-aware logical properties
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: CSS (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Dave Hyatt
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-20 13:01 PDT by Dave Hyatt
Modified: 2010-09-20 14:03 PDT (History)
0 users

See Also:


Attachments
Patch (33.69 KB, patch)
2010-09-20 13:25 PDT, Dave Hyatt
mitz: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Dave Hyatt 2010-09-20 13:01:49 PDT
We already have direction-aware properties like margin-start and margin-end.  This patch adds the -before/-after equivalents and updates everything to work with block-flow correctly.
Comment 1 Dave Hyatt 2010-09-20 13:25:41 PDT
Created attachment 68130 [details]
Patch
Comment 2 mitz 2010-09-20 14:00:16 PDT
Comment on attachment 68130 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68130&action=review

> WebCore/css/CSSProperty.cpp:67
> +            }
> +
> +        }

Extra newline
Comment 3 Dave Hyatt 2010-09-20 14:03:27 PDT
Fixed in r67882.