Bug 46113 - Two instances of commit-queue try to process the same patch
Summary: Two instances of commit-queue try to process the same patch
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-20 12:08 PDT by Adam Barth
Modified: 2010-09-20 12:33 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.57 KB, patch)
2010-09-20 12:10 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (1.61 KB, patch)
2010-09-20 12:15 PDT, Adam Barth 		no flags Details | Formatted Diff | Diff
Patch (1.62 KB, patch)
2010-09-20 12:24 PDT, Adam Barth 		eric: review+
Details | Formatted Diff | Diff
Show Obsolete (2) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-09-20 12:08:46 PDT 
Two instances of commit-queue try to process the same patch
Comment 1 Adam Barth 2010-09-20 12:10:10 PDT 
Created attachment 68119 [details]
Patch
Comment 2 Adam Barth 2010-09-20 12:15:30 PDT 
Created attachment 68120 [details]
Patch
Comment 3 Adam Barth 2010-09-20 12:24:42 PDT 
Created attachment 68122 [details]
Patch
Comment 4 Eric Seidel (no email) 2010-09-20 12:26:43 PDT 
Comment on attachment 68122 [details]
Patch

It's sorta sad that we're not including the bug id in this message.  We could change _get_next_patch_id to be _get_next_patch and to return teh bug_id as well.  Future code might want all message to have a bug id.

We really need testing for this stuff.
Comment 5 Adam Barth 2010-09-20 12:33:02 PDT 
Committed r67871: <http://trac.webkit.org/changeset/67871>