Bug 46111 - video-served-as-text.html failing on Windows
Summary: video-served-as-text.html failing on Windows
Status: RESOLVED DUPLICATE of bug 45603
Alias: None
Product: WebKit
Classification: Unclassified
Component: Media (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Windows 7
: P2 Normal
Assignee: Jer Noble
Keywords: InRadar
Depends on:
Reported: 2010-09-20 11:53 PDT by Eric Carlson
Modified: 2010-10-07 05:10 PDT (History)
1 user (show)

See Also:

Patch (2.46 KB, patch)
2010-10-06 17:27 PDT, Jer Noble
darin: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Eric Carlson 2010-09-20 11:53:10 PDT
LayoutTests/http/tests/media/video-served-as-text.html is failing on Windows, eg. http://trac.webkit.org/export/67846/trunk/LayoutTests/http/tests/media/video-served-as-text.html
Comment 1 Eric Carlson 2010-09-20 14:08:51 PDT
Test  skipped in http://trac.webkit.org/changeset/67883.
Comment 2 Eric Carlson 2010-09-20 14:21:39 PDT
Comment 3 Jer Noble 2010-10-06 17:27:48 PDT
Created attachment 70019 [details]
Comment 4 Darin Adler 2010-10-06 17:58:47 PDT
Comment on attachment 70019 [details]

View in context: https://bugs.webkit.org/attachment.cgi?id=70019&action=review

> WebCore/platform/graphics/win/QTMovie.cpp:65
> +static bool sDisabledComponents = 0;

The “s” prefix here is not WebKit style. I think we were talking about a style like s_disabledComponents for static data members, but I don’t think we planned to use a prefix at all for file-scoped globals.

But further, this global does not have to exist outside the disableUnsupportedComponents function. You can just put the static bool in there.

> WebCore/platform/graphics/win/QTMovie.cpp:279
> +    ComponentDescription components[] = {

Code needs a why comment.

> WebCore/platform/graphics/win/QTMovie.cpp:287
> +    ComponentDescription nullDesc = {'null', 'base', kAppleManufacturer, 0, 0};
> +    Component nullComp = FindNextComponent(0, &nullDesc);

I would like the code better if there was less Desc and Comp and more Description and Component.

> WebCore/platform/graphics/win/QTMovie.cpp:294
> +        Component disabledComp = 0;
> +        while (disabledComp = FindNextComponent(disabledComp, &components[i]))

Comment 5 Jer Noble 2010-10-06 18:21:48 PDT
Actually, I don't much like the way this code is factored either.  I'm going to submit a new patch which moves around where some of the implementation lives.
Comment 6 Jer Noble 2010-10-06 18:33:42 PDT
Embarrassing.  This bug is a duplicate of https://bugs.webkit.org/show_bug.cgi?id=45603.  The Radar was never updated with the original bugzilla bug.  Even more embarrassing, my two different implementations lived in entirely different places.  

No wonder I didn't like how it was factored!

I'm going to obsolete my patch, and hopefully we can all forget this ever happened.
Comment 7 Adam Roben (:aroben) 2010-10-07 05:10:57 PDT

*** This bug has been marked as a duplicate of bug 45603 ***