Bug 46107 - [BREWMP] Add dummy Pasteboard
Summary: [BREWMP] Add dummy Pasteboard
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 33564
  Show dependency tree / graph
 
Reported: 2010-09-20 11:33 PDT by Kwang Yul Seo
Modified: 2010-09-22 00:12 PDT (History)
1 user (show)

See Also:

Attachments
Patch (3.89 KB, patch)
2010-09-20 11:35 PDT, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-09-20 11:33:53 PDT 
Pasteboard is not supported yet.
Comment 1 Kwang Yul Seo 2010-09-20 11:35:11 PDT 
Created attachment 68115 [details]
Patch
Comment 2 Kent Tamura 2010-09-21 17:10:11 PDT 
Comment on attachment 68115 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68115&action=review

> WebCore/platform/brew/PasteboardBrew.cpp:55
> +void Pasteboard::writeSelection(Range* selectedRange, bool canSmartCopyOrDelete, Frame* frame)

nit: We usually omit parameter names if they are not used in the function content.
Comment 3 Kwang Yul Seo 2010-09-21 17:17:42 PDT 
(In reply to comment #2)
> (From update of attachment 68115 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=68115&action=review
> 
> > WebCore/platform/brew/PasteboardBrew.cpp:55
> > +void Pasteboard::writeSelection(Range* selectedRange, bool canSmartCopyOrDelete, Frame* frame)
> 
> nit: We usually omit parameter names if they are not used in the function content.

Thanks for the tip.
Comment 4 WebKit Commit Bot 2010-09-22 00:12:24 PDT 
Comment on attachment 68115 [details]
Patch

Clearing flags on attachment: 68115

Committed r68017: <http://trac.webkit.org/changeset/68017>
Comment 5 WebKit Commit Bot 2010-09-22 00:12:31 PDT 
All reviewed patches have been landed.  Closing bug.