RESOLVED FIXED Bug 46107
[BREWMP] Add dummy Pasteboard 
https://bugs.webkit.org/show_bug.cgi?id=46107
Summary [BREWMP] Add dummy Pasteboard
Kwang Yul Seo
Reported 2010-09-20 11:33:53 PDT
Pasteboard is not supported yet.
Attachments
Patch (3.89 KB, patch)
2010-09-20 11:35 PDT, Kwang Yul Seo 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Kwang Yul Seo
Comment 1 2010-09-20 11:35:11 PDT
Created attachment 68115 [details] Patch
Kent Tamura
Comment 2 2010-09-21 17:10:11 PDT
Comment on attachment 68115 [details] Patch View in context: https://bugs.webkit.org/attachment.cgi?id=68115&action=review > WebCore/platform/brew/PasteboardBrew.cpp:55 > +void Pasteboard::writeSelection(Range* selectedRange, bool canSmartCopyOrDelete, Frame* frame) nit: We usually omit parameter names if they are not used in the function content.
Kwang Yul Seo
Comment 3 2010-09-21 17:17:42 PDT
(In reply to comment #2) > (From update of attachment 68115 [details]) > View in context: https://bugs.webkit.org/attachment.cgi?id=68115&action=review > > > WebCore/platform/brew/PasteboardBrew.cpp:55 > > +void Pasteboard::writeSelection(Range* selectedRange, bool canSmartCopyOrDelete, Frame* frame) > > nit: We usually omit parameter names if they are not used in the function content. Thanks for the tip.
WebKit Commit Bot
Comment 4 2010-09-22 00:12:24 PDT
Comment on attachment 68115 [details] Patch Clearing flags on attachment: 68115 Committed r68017: <http://trac.webkit.org/changeset/68017>
WebKit Commit Bot
Comment 5 2010-09-22 00:12:31 PDT
All reviewed patches have been landed. Closing bug.
Note You need to log in before you can comment on or make changes to this bug.