Bug 46105 - [BREWMP] Add TextBoundaries and TextBreakIterator
Summary: [BREWMP] Add TextBoundaries and TextBreakIterator
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 33564
  Show dependency tree / graph
 
Reported: 2010-09-20 11:12 PDT by Kwang Yul Seo
Modified: 2010-10-13 17:55 PDT (History)
0 users

See Also:

Attachments
Patch (12.32 KB, patch)
2010-09-20 11:13 PDT, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-09-20 11:12:00 PDT 
Copy the code from WinCE port.
Comment 1 Kwang Yul Seo 2010-09-20 11:13:44 PDT 
Created attachment 68113 [details]
Patch
Comment 2 Kent Tamura 2010-10-13 17:16:54 PDT 
Comment on attachment 68113 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=68113&action=review

> WebCore/platform/text/brew/TextBoundariesBrew.cpp:37
> +int findNextWordFromIndex(const UChar * buffer, int len, int position, bool forward)

The position of "*" is noncommittal.  We usually use "const UChar* buffer".

> WebCore/platform/text/brew/TextBoundariesBrew.cpp:43
> +void findWordBoundary(const UChar * buffer, int len, int position, int* start, int* end)

ditto.
Comment 3 Kwang Yul Seo 2010-10-13 17:50:12 PDT 
Manually committed r69722: http://trac.webkit.org/changeset/69722
Comment 4 Kwang Yul Seo 2010-10-13 17:55:54 PDT 
Comment on attachment 68113 [details]
Patch

Clear flags on attachment 68113 [details]