Bug 46104 - [BREWMP] Handle tab key
Summary: [BREWMP] Handle tab key
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 33564
  Show dependency treegraph
 
Reported: 2010-09-20 11:04 PDT by Kwang Yul Seo
Modified: 2010-09-20 22:25 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.51 KB, patch)
2010-09-20 11:05 PDT, Kwang Yul Seo
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-09-20 11:04:34 PDT
In Brew MP, AVK_FUNCTION is the key code for tab. Process AVK_FUNCTION as tab in PlatformKeyboardEvent.
Comment 1 Kwang Yul Seo 2010-09-20 11:05:52 PDT
Created attachment 68112 [details]
Patch
Comment 2 Daniel Bates 2010-09-20 22:09:50 PDT
Comment on attachment 68112 [details]
Patch

Looks sane to me.

r=me
Comment 3 Kwang Yul Seo 2010-09-20 22:10:55 PDT
(In reply to comment #2)
> (From update of attachment 68112 [details])
> Looks sane to me.
> 
> r=me

Would you turn on the cq+ too?
Comment 4 Daniel Bates 2010-09-20 22:11:50 PDT
(In reply to comment #3)
> (In reply to comment #2)
> > (From update of attachment 68112 [details] [details])
> > Looks sane to me.
> > 
> > r=me
> 
> Would you turn on the cq+ too?

Done.
Comment 5 WebKit Commit Bot 2010-09-20 22:25:27 PDT
Comment on attachment 68112 [details]
Patch

Clearing flags on attachment: 68112

Committed r67925: <http://trac.webkit.org/changeset/67925>
Comment 6 WebKit Commit Bot 2010-09-20 22:25:32 PDT
All reviewed patches have been landed.  Closing bug.