Bug 46097 - [Qt] Make build work with QT_NO_CURSOR
Summary: [Qt] Make build work with QT_NO_CURSOR
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-20 08:55 PDT by Jakob Petsovits
Modified: 2010-10-05 08:52 PDT (History)
0 users

See Also:

Attachments
[Qt] Avoid GCC warning when QT_NO_CURSOR is defined (1.33 KB, patch)
2010-09-20 08:59 PDT, Jakob Petsovits 		kling: review+
Details | Formatted Diff | Diff
[Qt] Fix obvious build errors (1.50 KB, patch)
2010-09-20 09:01 PDT, Jakob Petsovits 		kling: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Jakob Petsovits 2010-09-20 08:55:05 PDT 
On Friday I tried building the Qt port with QT_NO_CURSOR because that spares me from adding further #ifdefs to my modified Qt/OpenVG port. Seems to me like nobody has actually tried enabling that define yet. Here's two patches that made my build work.
Comment 1 Jakob Petsovits 2010-09-20 08:59:19 PDT 
Created attachment 68090 [details]
[Qt] Avoid GCC warning when QT_NO_CURSOR is defined

For Qt, warnings are errors now, so this also breaks the build. Will add ChangeLog change and bug number on landing.
Comment 2 Jakob Petsovits 2010-09-20 09:01:35 PDT 
Created attachment 68091 [details]
[Qt] Fix obvious build errors

Those ones are actual errors, and make it pretty clear that this code has never actually been compiled. Will add ChangeLog and bug number when landing.
Comment 3 Andreas Kling 2010-09-20 09:52:21 PDT 
Comment on attachment 68090 [details]
[Qt] Avoid GCC warning when QT_NO_CURSOR is defined

r=me
Comment 4 Jakob Petsovits 2010-10-05 08:45:23 PDT 
Committed r69110: <http://trac.webkit.org/changeset/69110>
Comment 5 Jakob Petsovits 2010-10-05 08:52:52 PDT 
Committed r69111: <http://trac.webkit.org/changeset/69111>