Bug 46096 – Enable ARM VFP on hardware that defines VFP and isn't LINUX

• Status: RESOLVED
• Resolution: FIXED
• Component: JavaScriptCore

[David Tapuska]

The isVFPPresent implementation of MacroAssemblerARM.cpp could take into account the current compiler setting for setting the default of whether a VFP is present or not.

[David Tapuska]

Created attachment 68106 [details]
Add define to test if VFP is enabled by RVCT compiler

[Zoltan Herczeg]

Would be good to add the same condition for GCC as well.

[David Tapuska]

(In reply to comment #2)
> Would be good to add the same condition for GCC as well.

I'd be happy to add it but do you know what it defines when hardware FPU is set? I couldn't find the appropriate documentation on it.

[David Kilzer (:ddkilzer)]

(In reply to comment #3)
> (In reply to comment #2)
> > Would be good to add the same condition for GCC as well.
> 
> I'd be happy to add it but do you know what it defines when hardware FPU is set? I couldn't find the appropriate documentation on it.

It appears that Apple's gcc-4.2 compilers use __VFP_FP__:

$ gcc-4.2 -x c -arch armv6 -isysroot /Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS4.2.sdk -dM -E /dev/null | grep -i vfp
#define __VFP_FP__ 1

$ gcc-4.2 -x c -arch armv7 -isysroot /Developer/Platforms/iPhoneOS.platform/Developer/SDKs/iPhoneOS4.2.sdk -dM -E /dev/null | grep -i vfp
#define __VFP_FP__ 1

[David Kilzer (:ddkilzer)]

Comment on attachment 68106 [details]
Add define to test if VFP is enabled by RVCT compiler

r- to include support for gcc as well.  Otherwise this looks good!

[David Kilzer (:ddkilzer)]

Comment on attachment 68106 [details]
Add define to test if VFP is enabled by RVCT compiler

View in context: https://bugs.webkit.org/attachment.cgi?id=68106&action=review

> JavaScriptCore/assembler/MacroAssemblerARM.cpp:59
> +#if defined(__TARGET_FPU_VFP)

Also, I think you should add compiler checks:

    #if COMPILER(RVCT) && defined(__TARGET_FPU_VFP) || COMPILER(GCC) && defined(__VFP_FP__)

[David Tapuska]

Created attachment 71742 [details]
Add GCC defines to VFP present setting

[WebKit Review Bot]

Attachment 71742 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/assembler/MacroAssemblerARM.cpp:59:  More than one command on the same line in if  [whitespace/parens] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[David Kilzer (:ddkilzer)]

Comment on attachment 71742 [details]
Add GCC defines to VFP present setting

View in context: https://bugs.webkit.org/attachment.cgi?id=71742&action=review

Thanks!  r=me

> JavaScriptCore/assembler/MacroAssemblerARM.cpp:-59
> -

Nit: I would leave this blank line in place.

[David Tapuska]

Created attachment 71755 [details]
Add GCC defines to VFP present setting preserving line 59

[WebKit Review Bot]

Attachment 71755 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/assembler/MacroAssemblerARM.cpp:60:  More than one command on the same line in if  [whitespace/parens] [4]
Total errors found: 1 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

[David Kilzer (:ddkilzer)]

Comment on attachment 71755 [details]
Add GCC defines to VFP present setting preserving line 59

r=me

[Eric Seidel (no email)]

Comment on attachment 71742 [details]
Add GCC defines to VFP present setting

Cleared David Kilzer's review+ from obsolete attachment 71742 [details] so that this bug does not appear in http://webkit.org/pending-commit.

[WebKit Commit Bot]

The commit-queue encountered the following flaky tests while processing attachment 71755 [details]:

http/tests/appcache/fail-on-update.html

Please file bugs against the tests.  The author(s) of the test(s) are [e-mail], [e-mail], and [e-mail].  The commit-queue is continuing to process your patch.

[WebKit Commit Bot]

Comment on attachment 71755 [details]
Add GCC defines to VFP present setting preserving line 59

Clearing flags on attachment: 71755

Committed r70474: <http://trac.webkit.org/changeset/70474>

[WebKit Commit Bot]

All reviewed patches have been landed.  Closing bug.