Bug 46074 - [reviewtool] Publish button should actually publish the review comments
Summary: [reviewtool] Publish button should actually publish the review comments
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Adam Barth
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-19 22:21 PDT by Adam Barth
Modified: 2010-09-20 09:38 PDT (History)
2 users (show)

See Also:


Attachments
Patch (1.37 KB, patch)
2010-09-19 22:22 PDT, Adam Barth
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Adam Barth 2010-09-19 22:21:15 PDT
[reviewtool] Publish button should actually publish the review comments
Comment 1 Adam Barth 2010-09-19 22:22:52 PDT
Created attachment 68051 [details]
Patch
Comment 2 Adam Barth 2010-09-19 23:16:44 PDT
Comment on attachment 68051 [details]
Patch

Clearing flags on attachment: 68051

Committed r67839: <http://trac.webkit.org/changeset/67839>
Comment 3 Adam Barth 2010-09-19 23:16:49 PDT
All reviewed patches have been landed.  Closing bug.
Comment 4 Alexey Proskuryakov 2010-09-20 08:38:24 PDT
+        publishes the comments directly.  If there's demand for a "Preview"
+        button, we can find a way to add that feature.

That would be a useful addition.
Comment 5 Joseph Pecoraro 2010-09-20 09:38:21 PDT
(In reply to comment #4)
> +        publishes the comments directly.  If there's demand for a "Preview"
> +        button, we can find a way to add that feature.
> 
> That would be a useful addition.

I agree!