Bug 46055 – http/tests/security/xssAuditor/link-opens-new-window.html doesn't pass with Chromium DRT

• Status: RESOLVED
• Resolution: DUPLICATE
• Component: Tools / Tests

[Mihai Parparita]

http/tests/security/xssAuditor/link-opens-new-window.html doesn't pass with Chromium DRT

[Mihai Parparita]

Created attachment 68029 [details]
Patch

[Mihai Parparita]

Another option is to copy all of the WebSettings from the parent WebView into the newly created one (not sure how many other settings we'd want to actually propagate though).

[Adam Barth]

What do you think tkent?

[Mihai Parparita]

FWIW, this works in test_shell because the XSS auditor is a global flag there:

http://www.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/webkit/tools/test_shell/layout_test_controller.cc&q=xssauditor%20file:test_shell&exact_package=chromium&sa=N&cd=1&ct=rc&l=1070

And on the Mac DRT, unless otherwise overridden (which is not the case here) all WebViews use the same WebPreferences instance (from [WebPreferences standardPreferences]):

http://www.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/third_party/WebKit/WebKitTools/DumpRenderTree/mac/LayoutTestControllerMac.mm&q=xssauditor%20file:dumprendertree%20file:mac&exact_package=chromium&sa=N&cd=2&ct=rc&l=410

http://www.google.com/codesearch/p?hl=en#OAMlx_jo-ck/src/third_party/WebKit/WebKit/mac/WebView/WebView.h&q=webview%20preferences%20file:mac&exact_package=chromium&l=460

[Adam Barth]

This seems related to this recent change by tkent:

http://trac.webkit.org/changeset/67809

[Mihai Parparita]

Nevermind, I see this got fixed with http://trac.webkit.org/changeset/67809, not sure how I didn't see that this morning.

*** This bug has been marked as a duplicate of bug 45945 ***

[Dimitri Glazkov (Google)]

Comment on attachment 68029 [details]
Patch

clearing review flags to remove from queue.