Bug 46054 - Replace WKBundleRangeRef with WKBundleRangeHandleRef.
Summary: Replace WKBundleRangeRef with WKBundleRangeHandleRef.
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKit2 (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-19 10:29 PDT by Sam Weinig
Modified: 2010-09-19 11:26 PDT (History)
2 users (show)

See Also:

Attachments
Patch (63.15 KB, patch)
2010-09-19 10:32 PDT, Sam Weinig 		andersca: review+
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Sam Weinig 2010-09-19 10:29:11 PDT 
Replace WKBundleRangeRef with WKBundleRangeHandleRef.
Comment 1 Sam Weinig 2010-09-19 10:32:35 PDT 
Created attachment 68028 [details]
Patch
Comment 2 WebKit Review Bot 2010-09-19 10:37:53 PDT 
Attachment 68028 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:34:  Code inside a namespace should not be indented.  [whitespace/indent] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.cpp:26:  Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:52:  More than one command on the same line  [whitespace/newline] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:54:  More than one command on the same line  [whitespace/newline] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:56:  More than one command on the same line  [whitespace/newline] [4]
WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:63:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 7 in 22 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2010-09-19 10:41:01 PDT 
Landed in r67813.
Comment 4 Csaba Osztrogonác 2010-09-19 11:01:06 PDT 
It seems this patch broke QtWebKit build. Could you fix it?
http://build.webkit.org/builders/Qt%20Linux%20Release/builds/20209/steps/compile-webkit/logs/stdio
Comment 5 Csaba Osztrogonác 2010-09-19 11:26:20 PDT 
Qt buildfix landed in http://trac.webkit.org/changeset/67815