RESOLVED FIXED 46054
Replace WKBundleRangeRef with WKBundleRangeHandleRef. 
https://bugs.webkit.org/show_bug.cgi?id=46054
Summary Replace WKBundleRangeRef with WKBundleRangeHandleRef.
Sam Weinig
Reported 2010-09-19 10:29:11 PDT
Replace WKBundleRangeRef with WKBundleRangeHandleRef.
Attachments
Patch (63.15 KB, patch)
2010-09-19 10:32 PDT, Sam Weinig 		andersca: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-09-19 10:32:35 PDT
Created attachment 68028 [details] Patch
WebKit Review Bot
Comment 2 2010-09-19 10:37:53 PDT
Attachment 68028 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/WebProcess/InjectedBundle/DOM/InjectedBundleRangeHandle.h:34: Code inside a namespace should not be indented. [whitespace/indent] [4] WebKit2/WebProcess/InjectedBundle/API/c/WKBundleRangeHandle.cpp:26: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4] WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:52: More than one command on the same line [whitespace/newline] [4] WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:54: More than one command on the same line [whitespace/newline] [4] WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:56: More than one command on the same line [whitespace/newline] [4] WebKit2/WebProcess/InjectedBundle/API/c/WKBundleAPICast.h:63: More than one command on the same line [whitespace/newline] [4] Total errors found: 7 in 22 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2010-09-19 10:41:01 PDT
Landed in r67813.
Csaba Osztrogonác
Comment 4 2010-09-19 11:01:06 PDT
It seems this patch broke QtWebKit build. Could you fix it? http://build.webkit.org/builders/Qt%20Linux%20Release/builds/20209/steps/compile-webkit/logs/stdio
Csaba Osztrogonác
Comment 5 2010-09-19 11:26:20 PDT
Qt buildfix landed in http://trac.webkit.org/changeset/67815
Note You need to log in before you can comment on or make changes to this bug.