Bug 46046 - Add unit tests for diffs that delete or modify a change log entry or describe changes that are far apart
Summary: Add unit tests for diffs that delete or modify a change log entry or describe...
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Daniel Bates
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-18 18:16 PDT by Daniel Bates
Modified: 2010-09-19 19:41 PDT (History)
2 users (show)

See Also:

Attachments
Unit tests (3.41 KB, patch)
2010-09-18 18:26 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Unit tests (3.38 KB, patch)
2010-09-18 18:30 PDT, Daniel Bates 		no flags Details | Formatted Diff | Diff
Show Obsolete (1) View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Daniel Bates 2010-09-18 18:16:50 PDT 
We could use additional test coverage for VCSUtils::fixChangeLogPatch. In particular, we don't seem to have test coverage for the early return on line 1324 of VCSUtils.pm <http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/VCSUtils.pm?rev=66800#L1324>.

For instance, this early return is taken for a diff that contains deletions (such as removing or modifying a change log entry), or has changes that are far apart from each other.
Comment 1 Daniel Bates 2010-09-18 18:26:41 PDT 
Created attachment 68021 [details]
Unit tests
Comment 2 WebKit Review Bot 2010-09-18 18:28:15 PDT 
Attachment 68021 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:64:  Line contains tab character.  [whitespace/tab] [5]
WebKitTools/Scripts/webkitperl/VCSUtils_unittest/fixChangeLogPatch.pl:65:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 2 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Daniel Bates 2010-09-18 18:30:01 PDT 
Created attachment 68022 [details]
Unit tests
Comment 4 Martin Robinson 2010-09-19 15:45:20 PDT 
Comment on attachment 68022 [details]
Unit tests

Looks sane!
Comment 5 Daniel Bates 2010-09-19 19:41:22 PDT 
Comment on attachment 68022 [details]
Unit tests

Clearing flags on attachment: 68022

Committed r67832: <http://trac.webkit.org/changeset/67832>
Comment 6 Daniel Bates 2010-09-19 19:41:28 PDT 
All reviewed patches have been landed.  Closing bug.