RESOLVED FIXED46043
Improve/unify the PageLoadClient interfaces 
https://bugs.webkit.org/show_bug.cgi?id=46043
Summary Improve/unify the PageLoadClient interfaces
Sam Weinig
Reported 2010-09-18 16:47:18 PDT
Improve/unify the PageLoadClient interfaces.
Attachments
Patch (75.52 KB, patch)
2010-09-18 16:48 PDT, Sam Weinig 		mitz: review+
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Sam Weinig
Comment 1 2010-09-18 16:48:16 PDT
Created attachment 68018 [details] Patch
WebKit Review Bot
Comment 2 2010-09-18 16:53:59 PDT
Attachment 68018 [details] did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:84: Extra space between WKBundlePageDidFirstLayoutForFrame and didFirstLayoutForFrame [whitespace/declaration] [3] WebKit2/WebProcess/InjectedBundle/API/c/WKBundlePage.h:85: Extra space between WKBundlePageDidFirstVisuallyNonEmptyLayoutForFrame and didFirstVisuallyNonEmptyLayoutForFrame [whitespace/declaration] [3] Total errors found: 2 in 17 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3 2010-09-18 17:31:23 PDT
Landed in http://trac.webkit.org/changeset/67802.
Csaba Osztrogonác
Comment 4 2010-09-19 10:52:16 PDT
Qt buildfix landed in http://trac.webkit.org/changeset/67814. Please take notice of red "Qt Linux Release" buildbot next time. Build errors were that: ../../../WebKit2/UIProcess/API/qt/qwkpage.cpp: In constructor ‘QWKPage::QWKPage(const OpaqueWKPageNamespace*)’: ../../../WebKit2/UIProcess/API/qt/qwkpage.cpp:249: error: invalid conversion from ‘void (*)(const OpaqueWKPage*, const OpaqueWKFrame*, const void*)’ to ‘void (*)(const OpaqueWKPage*, const OpaqueWKFrame*, const void*, const void*)’ ../../../WebKit2/UIProcess/API/qt/qwkpage.cpp:249: error: invalid conversion from ‘void (*)(const OpaqueWKPage*, const OpaqueWKFrame*, const void*)’ to ‘void (*)(const OpaqueWKPage*, const OpaqueWKFrame*, const void*, const void*)’ ../../../WebKit2/UIProcess/API/qt/qwkpage.cpp:249: error: invalid conversion from ‘void (*)(const OpaqueWKPage*, const OpaqueWKFrame*, const void*)’ to ‘void (*)(const OpaqueWKPage*, const OpaqueWKFrame*, const void*, const void*)’ ../../../WebKit2/UIProcess/API/qt/qwkpage.cpp:249: error: invalid conversion from ‘void (*)(const OpaqueWKPage*, const OpaqueWKFrame*, const void*)’ to ‘void (*)(const OpaqueWKPage*, const OpaqueWKFrame*, const void*, const void*)’ ../../../WebKit2/UIProcess/API/qt/qwkpage.cpp:249: error: invalid conversion from ‘void (*)(const OpaqueWKPage*, const OpaqueWKFrame*, const void*)’ to ‘void (*)(const OpaqueWKPage*, const OpaqueWKFrame*, const void*, const void*)’ ../../../WebKit2/UIProcess/API/qt/qwkpage.cpp:249: error: invalid conversion from ‘void (*)(const OpaqueWKPage*, const OpaqueWKFrame*, const void*)’ to ‘void (*)(const OpaqueWKPage*, const OpaqueWKFrame*, const void*, const void*)’ ../../../WebKit2/UIProcess/API/qt/qwkpage.cpp:249: error: invalid conversion from ‘void (*)(const OpaqueWKPage*, const OpaqueWKFrame*, const void*)’ to ‘void (*)(const OpaqueWKPage*, const OpaqueWKFrame*, const void*, const void*)’ ../../../WebKit2/UIProcess/API/qt/qwkpage.cpp:249: error: invalid conversion from ‘void (*)(const OpaqueWKPage*, const OpaqueWKString*, const OpaqueWKFrame*, const void*)’ to ‘void (*)(const OpaqueWKPage*, const OpaqueWKString*, const OpaqueWKFrame*, const void*, const void*)’ ../../../WebKit2/UIProcess/API/qt/qwkpage.cpp:249: error: invalid conversion from ‘void (*)(const OpaqueWKPage*, const OpaqueWKFrame*, const void*)’ to ‘void (*)(const OpaqueWKPage*, const OpaqueWKFrame*, const void*, const void*)’ ../../../WebKit2/UIProcess/API/qt/qwkpage.cpp:249: error: invalid conversion from ‘void (*)(const OpaqueWKPage*, const OpaqueWKFrame*, const void*)’ to ‘void (*)(const OpaqueWKPage*, const OpaqueWKFrame*, const void*, const void*)’
Note You need to log in before you can comment on or make changes to this bug.