Bug 46038 - [GTK] Clean up the DRT fonts.conf and switch to Liberation
Summary: [GTK] Clean up the DRT fonts.conf and switch to Liberation
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: WebKitGTK (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC Linux
: P3 Normal
Assignee: Nobody
URL:
Keywords: Gtk
Depends on:
Blocks: 36548
  Show dependency treegraph
 
Reported: 2010-09-18 09:04 PDT by Martin Robinson
Modified: 2010-09-27 12:03 PDT (History)
7 users (show)

See Also:


Attachments
Patch for this issue (27.27 KB, patch)
2010-09-18 09:16 PDT, Martin Robinson
gustavo: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Martin Robinson 2010-09-18 09:04:13 PDT
For the reasons outlined here (https://bugs.webkit.org/show_bug.cgi?id=46031), we should switch to a simpler DRT setup. Using Liberation for the time being is fairly low-risk, as it is advertised to be metric-compatible with Microsoft fonts. We can easily switch to those in the future. It's also quite simple to install these fonts on Fedora and Debians.

This patch removes the need to set WEBKIT_TESTFONTS, but does look for the fonts to be installed in certain locations. This patch will require many rebaselines, which are best done right before landing.
Comment 1 Martin Robinson 2010-09-18 09:04:40 PDT
(In reply to comment #0)
> For the reasons outlined here (https://bugs.webkit.org/show_bug.cgi?id=46031), 

This link should be: https://lists.webkit.org/pipermail/webkit-gtk/2010-September/000326.html
Comment 2 Martin Robinson 2010-09-18 09:16:40 PDT
Created attachment 68011 [details]
Patch for this issue
Comment 3 Gustavo Noronha (kov) 2010-09-24 10:48:26 PDT
Comment on attachment 68011 [details]
Patch for this issue

View in context: https://bugs.webkit.org/attachment.cgi?id=68011&action=review

Makes sense to me, will be good to not have to set this variable anymore =). Keep on fighting the good fight!

> WebKitTools/DumpRenderTree/gtk/fonts/fonts.conf:5
> +    <!-- The sans-serif font should be Liberation Serif -->

The serif font, I believe?
Comment 4 Martin Robinson 2010-09-27 10:50:31 PDT
Committed r68403: <http://trac.webkit.org/changeset/68403>
Comment 5 WebKit Review Bot 2010-09-27 12:03:56 PDT
http://trac.webkit.org/changeset/68403 might have broken GTK Linux 64-bit Debug
The following changes are on the blame list:
http://trac.webkit.org/changeset/68403
http://trac.webkit.org/changeset/68404
http://trac.webkit.org/changeset/68405
http://trac.webkit.org/changeset/68406