WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
Bug 46038
[GTK] Clean up the DRT fonts.conf and switch to Liberation
https://bugs.webkit.org/show_bug.cgi?id=46038
Summary
[GTK] Clean up the DRT fonts.conf and switch to Liberation
Martin Robinson
Reported
2010-09-18 09:04:13 PDT
For the reasons outlined here (
https://bugs.webkit.org/show_bug.cgi?id=46031
), we should switch to a simpler DRT setup. Using Liberation for the time being is fairly low-risk, as it is advertised to be metric-compatible with Microsoft fonts. We can easily switch to those in the future. It's also quite simple to install these fonts on Fedora and Debians. This patch removes the need to set WEBKIT_TESTFONTS, but does look for the fonts to be installed in certain locations. This patch will require many rebaselines, which are best done right before landing.
Attachments
Patch for this issue
(27.27 KB, patch)
2010-09-18 09:16 PDT
,
Martin Robinson
gustavo
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Martin Robinson
Comment 1
2010-09-18 09:04:40 PDT
(In reply to
comment #0
)
> For the reasons outlined here (
https://bugs.webkit.org/show_bug.cgi?id=46031
),
This link should be:
https://lists.webkit.org/pipermail/webkit-gtk/2010-September/000326.html
Martin Robinson
Comment 2
2010-09-18 09:16:40 PDT
Created
attachment 68011
[details]
Patch for this issue
Gustavo Noronha (kov)
Comment 3
2010-09-24 10:48:26 PDT
Comment on
attachment 68011
[details]
Patch for this issue View in context:
https://bugs.webkit.org/attachment.cgi?id=68011&action=review
Makes sense to me, will be good to not have to set this variable anymore =). Keep on fighting the good fight!
> WebKitTools/DumpRenderTree/gtk/fonts/fonts.conf:5 > + <!-- The sans-serif font should be Liberation Serif -->
The serif font, I believe?
Martin Robinson
Comment 4
2010-09-27 10:50:31 PDT
Committed
r68403
: <
http://trac.webkit.org/changeset/68403
>
WebKit Review Bot
Comment 5
2010-09-27 12:03:56 PDT
http://trac.webkit.org/changeset/68403
might have broken GTK Linux 64-bit Debug The following changes are on the blame list:
http://trac.webkit.org/changeset/68403
http://trac.webkit.org/changeset/68404
http://trac.webkit.org/changeset/68405
http://trac.webkit.org/changeset/68406
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug