Bug 46032 - check-webkit-style complains about unincluded config.h in WebKit2 code
Summary: check-webkit-style complains about unincluded config.h in WebKit2 code
Status: RESOLVED DUPLICATE of bug 48638
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC All
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-18 05:35 PDT by Andras Becsi
Modified: 2010-11-02 14:01 PDT (History)
4 users (show)

See Also:

Attachments
Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Andras Becsi 2010-09-18 05:35:21 PDT 
In WebKit2 code including config.h is not needed but check-webkit-style complains about it's absence:

Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted.  [build/include_order] [4]
Comment 1 Csaba Osztrogonác 2010-09-21 03:57:34 PDT 
Additionally we should mention in "WebKit Coding Style Guidelines"
that including config.h is unnecessary.
Comment 2 David Levin 2010-11-02 14:01:47 PDT 
Sounds like this was fixed in 48638.

*** This bug has been marked as a duplicate of bug 48638 ***