WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED DUPLICATE of
bug 48638
46032
check-webkit-style complains about unincluded config.h in WebKit2 code
https://bugs.webkit.org/show_bug.cgi?id=46032
Summary
check-webkit-style complains about unincluded config.h in WebKit2 code
Andras Becsi
Reported
2010-09-18 05:35:21 PDT
In WebKit2 code including config.h is not needed but check-webkit-style complains about it's absence: Found header this file implements before WebCore config.h. Should be: config.h, primary header, blank line, and then alphabetically sorted. [build/include_order] [4]
Attachments
Add attachment
proposed patch, testcase, etc.
Csaba Osztrogonác
Comment 1
2010-09-21 03:57:34 PDT
Additionally we should mention in "WebKit Coding Style Guidelines" that including config.h is unnecessary.
David Levin
Comment 2
2010-11-02 14:01:47 PDT
Sounds like this was fixed in 48638. *** This bug has been marked as a duplicate of
bug 48638
***
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug