Bug 46028 - [FileSystem] Fix Flags handling in DirectoryEntry custom binding code
: [FileSystem] Fix Flags handling in DirectoryEntry custom binding code
: WebKit
WebCore Misc.
: 528+ (Nightly build)
: PC Mac OS X 10.5
: P2 Normal
Assigned To:
: 42903
  Show dependency treegraph
Reported: 2010-09-17 22:57 PST by
Modified: 2010-09-30 13:39 PST (History)

Patch (11.54 KB, patch)
2010-09-17 23:03 PST, Kinuko Yasuda
dumi: review+
Review Patch | Details | Formatted Diff | Diff


You need to log in before you can comment on or make changes to this bug.

Description From 2010-09-17 22:57:42 PST
DirectoryEntry's custom code added by issue 45724 for FileSystem API has wrong RefPtr handling.

When the given flags argument is an instance of Flags object, the custom code calls adoptRef to get a RefPtr from a raw Flags pointer returned by toFlags/toNative.
However, toFlags/toNative returns an already adopted pointer so it should just assign the returned pointer rather than adopt assignment (the latter doesn't increment refCount).
------- Comment #1 From 2010-09-17 23:03:28 PST -------
Created an attachment (id=67997) [details]
------- Comment #2 From 2010-09-20 13:52:06 PST -------
(From update of attachment 67997 [details])

toFlags() returns a ref-counted object, because WebCore::Flags is ref-counted, right? if this is correct, it might be nice to mention this in the ChangeLog file (to make sure we don't copy-paste this code for some other class, and automatically assume that toNewClass() will be ref-counted too, when it might not be).
------- Comment #3 From 2010-09-22 17:59:12 PST -------
Committed r68105: <http://trac.webkit.org/changeset/68105>