Bug 46022 - New buildbot background colors make text harder to read
Summary: New buildbot background colors make text harder to read
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Tools / Tests (show other bugs)
Version: 528+ (Nightly build)
Hardware: PC OS X 10.5
: P2 Normal
Assignee: Brian Weinstein
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-17 17:53 PDT by Brian Weinstein
Modified: 2010-09-17 18:02 PDT (History)
2 users (show)

See Also:

Attachments
[PATCH] Fix (1.98 KB, patch)
2010-09-17 17:53 PDT, Brian Weinstein 		jhoneycutt: review+
bweinstein: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Brian Weinstein 2010-09-17 17:53:00 PDT 
The background colors on build.webkit.org/waterfall (especially the success and failure backgrounds) make the text harder to read. We should get these back to the colors that they were before the buildbot master upgrade.
Comment 1 Brian Weinstein 2010-09-17 17:53:52 PDT 
Created attachment 67982 [details]
[PATCH] Fix
Comment 2 WebKit Review Bot 2010-09-17 17:55:53 PDT 
Attachment 67982 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css:334:  Line contains tab character.  [whitespace/tab] [5]
WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css:340:  Line contains tab character.  [whitespace/tab] [5]
WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css:346:  Line contains tab character.  [whitespace/tab] [5]
WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css:352:  Line contains tab character.  [whitespace/tab] [5]
WebKitTools/BuildSlaveSupport/build.webkit.org-config/public_html/default.css:358:  Line contains tab character.  [whitespace/tab] [5]
Total errors found: 5 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Brian Weinstein 2010-09-17 18:02:48 PDT 
Landed in http://trac.webkit.org/projects/webkit/changeset/67768.