Bug 46018 – Add IsFloatingPoint and IsArithmetic type traits

Bug 46018 - Add IsFloatingPoint and IsArithmetic type traits


Summary:	Add IsFloatingPoint and IsArithmetic type traits

Status:	RESOLVED FIXED

Product:	WebKit
Component:	Web Template Framework
Version:	528+ (Nightly build)
Platform:	Other Mac OS X 10.5

Importance:	P2 Normal
Assigned To:	Anders Carlsson

URL:
Keywords:

Depends on:
Blocks:
	Show dependency tree / graph

Reported:	2010-09-17 17:25 PST by Anders Carlsson
Modified:	2010-09-17 17:41 PST (History)

Attachments
Patch (2.16 KB, patch) 2010-09-17 17:27 PST, Anders Carlsson	sam: review+	Review Patch \| Details \| Formatted Diff \| Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note

You need to log in before you can comment on or make changes to this bug.

Description From Anders Carlsson 2010-09-17 17:25:55 PST

Add IsFloatingPoint and IsArithmetic type traits

------- Comment #1 From Anders Carlsson 2010-09-17 17:27:59 PST -------

Created an attachment (id=67978) [details]
Patch

------- Comment #2 From WebKit Review Bot 2010-09-17 17:31:35 PST -------

Attachment 67978 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/wtf/TypeTraits.h:65:  More than one command on the same line  [whitespace/newline] [4]
JavaScriptCore/wtf/TypeTraits.h:66:  More than one command on the same line  [whitespace/newline] [4]
JavaScriptCore/wtf/TypeTraits.h:67:  More than one command on the same line  [whitespace/newline] [4]
JavaScriptCore/wtf/TypeTraits.h:68:  More than one command on the same line  [whitespace/newline] [4]
JavaScriptCore/wtf/TypeTraits.h:70:  More than one command on the same line  [whitespace/newline] [4]
JavaScriptCore/wtf/TypeTraits.h:74:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 6 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.

------- Comment #3 From Sam Weinig 2010-09-17 17:32:43 PST -------

(From update of attachment 67978 [details])
You should add tests in the .cpp file (as COMPILE_ASSERTS).

------- Comment #4 From Anders Carlsson 2010-09-17 17:41:18 PST -------

Committed r67765: <http://trac.webkit.org/changeset/67765>