WebKit Bugzilla
New
Browse
Log In
×
Sign in with GitHub
or
Remember my login
Create Account
·
Forgot Password
Forgotten password account recovery
RESOLVED FIXED
46018
Add IsFloatingPoint and IsArithmetic type traits
https://bugs.webkit.org/show_bug.cgi?id=46018
Summary
Add IsFloatingPoint and IsArithmetic type traits
Anders Carlsson
Reported
2010-09-17 17:25:55 PDT
Add IsFloatingPoint and IsArithmetic type traits
Attachments
Patch
(2.16 KB, patch)
2010-09-17 17:27 PDT
,
Anders Carlsson
sam
: review+
Details
Formatted Diff
Diff
View All
Add attachment
proposed patch, testcase, etc.
Anders Carlsson
Comment 1
2010-09-17 17:27:59 PDT
Created
attachment 67978
[details]
Patch
WebKit Review Bot
Comment 2
2010-09-17 17:31:35 PDT
Attachment 67978
[details]
did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 JavaScriptCore/wtf/TypeTraits.h:65: More than one command on the same line [whitespace/newline] [4] JavaScriptCore/wtf/TypeTraits.h:66: More than one command on the same line [whitespace/newline] [4] JavaScriptCore/wtf/TypeTraits.h:67: More than one command on the same line [whitespace/newline] [4] JavaScriptCore/wtf/TypeTraits.h:68: More than one command on the same line [whitespace/newline] [4] JavaScriptCore/wtf/TypeTraits.h:70: More than one command on the same line [whitespace/newline] [4] JavaScriptCore/wtf/TypeTraits.h:74: More than one command on the same line [whitespace/newline] [4] Total errors found: 6 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style.
Sam Weinig
Comment 3
2010-09-17 17:32:43 PDT
Comment on
attachment 67978
[details]
Patch You should add tests in the .cpp file (as COMPILE_ASSERTS).
Anders Carlsson
Comment 4
2010-09-17 17:41:18 PDT
Committed
r67765
: <
http://trac.webkit.org/changeset/67765
>
Note
You need to
log in
before you can comment on or make changes to this bug.
Top of Page
Format For Printing
XML
Clone This Bug