Bug 46018 - Add IsFloatingPoint and IsArithmetic type traits
: Add IsFloatingPoint and IsArithmetic type traits
Status: RESOLVED FIXED
Product: WebKit
Classification: Unclassified
Component: Web Template Framework
: 528+ (Nightly build)
: Other Mac OS X 10.5
: P2 Normal
Assigned To: Anders Carlsson
:
Depends on:
Blocks:
  Show dependency treegraph
 
Reported: 2010-09-17 17:25 PDT by Anders Carlsson
Modified: 2010-09-17 17:41 PDT (History)
1 user (show)

See Also:


Attachments
Patch (2.16 KB, patch)
2010-09-17 17:27 PDT, Anders Carlsson
sam: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Anders Carlsson 2010-09-17 17:25:55 PDT
Add IsFloatingPoint and IsArithmetic type traits
Comment 1 Anders Carlsson 2010-09-17 17:27:59 PDT
Created attachment 67978 [details]
Patch
Comment 2 WebKit Review Bot 2010-09-17 17:31:35 PDT
Attachment 67978 [details] did not pass style-queue:

Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1
JavaScriptCore/wtf/TypeTraits.h:65:  More than one command on the same line  [whitespace/newline] [4]
JavaScriptCore/wtf/TypeTraits.h:66:  More than one command on the same line  [whitespace/newline] [4]
JavaScriptCore/wtf/TypeTraits.h:67:  More than one command on the same line  [whitespace/newline] [4]
JavaScriptCore/wtf/TypeTraits.h:68:  More than one command on the same line  [whitespace/newline] [4]
JavaScriptCore/wtf/TypeTraits.h:70:  More than one command on the same line  [whitespace/newline] [4]
JavaScriptCore/wtf/TypeTraits.h:74:  More than one command on the same line  [whitespace/newline] [4]
Total errors found: 6 in 2 files


If any of these errors are false positives, please file a bug against check-webkit-style.
Comment 3 Sam Weinig 2010-09-17 17:32:43 PDT
Comment on attachment 67978 [details]
Patch

You should add tests in the .cpp file (as COMPILE_ASSERTS).
Comment 4 Anders Carlsson 2010-09-17 17:41:18 PDT
Committed r67765: <http://trac.webkit.org/changeset/67765>