Bug 46014 - add a script for running webkit_unit_tests
Summary: add a script for running webkit_unit_tests
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: New Bugs (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other OS X 10.5
: P2 Normal
Assignee: Tony Chang
URL:
Keywords:
Depends on:
Blocks:
 
Reported: 2010-09-17 16:57 PDT by Tony Chang
Modified: 2010-09-21 10:52 PDT (History)
0 users

See Also:


Attachments
Patch (3.11 KB, patch)
2010-09-17 16:59 PDT, Tony Chang
tkent: review+
Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Tony Chang 2010-09-17 16:57:53 PDT
add a script for running webkit_unit_tests
Comment 1 Tony Chang 2010-09-17 16:59:34 PDT
Created attachment 67973 [details]
Patch
Comment 2 Tony Chang 2010-09-17 17:00:33 PDT
We want to run webkit_unit_tests on the webkit.org buildbot.  It seems consistent with the rest of WebKit to have a wrapper script to run the tests (and makes the buildbot changes smaller).
Comment 3 Kent Tamura 2010-09-20 20:22:07 PDT
Comment on attachment 67973 [details]
Patch

View in context: https://bugs.webkit.org/attachment.cgi?id=67973&action=review

> WebKitTools/Scripts/run-chromium-webkit-unit-tests:1
> +#!/usr/bin/perl

Should it be "#!/usr/bin/env perl"?
Comment 4 Tony Chang 2010-09-21 10:50:38 PDT
Committed r67965: <http://trac.webkit.org/changeset/67965>
Comment 5 Tony Chang 2010-09-21 10:52:21 PDT
(In reply to comment #3)
> (From update of attachment 67973 [details])
> View in context: https://bugs.webkit.org/attachment.cgi?id=67973&action=review
> 
> > WebKitTools/Scripts/run-chromium-webkit-unit-tests:1
> > +#!/usr/bin/perl
> 
> Should it be "#!/usr/bin/env perl"?

I ended up using #!/usr/bin/perl -w because that's the most common:

> head -1 * | grep "#\!/" | sort | uniq -c
      1 #!/bin/sh
     12 #!/usr/bin/env python
      3 #!/usr/bin/env ruby
     21 #!/usr/bin/perl
     49 #!/usr/bin/perl -w
      2 #!/usr/bin/python
      1 #!/usr/bin/ruby