Bug 46005 - [BREWMP] Wrong key code type in keyIdentifierForBrewKeyCode
Summary: [BREWMP] Wrong key code type in keyIdentifierForBrewKeyCode
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 33564
  Show dependency tree / graph
 
Reported: 2010-09-17 15:36 PDT by Kwang Yul Seo
Modified: 2010-09-18 15:48 PDT (History)
1 user (show)

See Also:

Attachments
Patch (1.17 KB, patch)
2010-09-17 15:37 PDT, Kwang Yul Seo 		no flags Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-09-17 15:36:19 PDT 
The type of key code in Brew MP is uint16. Take uint16 instead of int16 in keyIdentifierForBrewKeyCode.
Comment 1 Kwang Yul Seo 2010-09-17 15:37:27 PDT 
Created attachment 67964 [details]
Patch
Comment 2 Andreas Kling 2010-09-17 19:09:33 PDT 
Comment on attachment 67964 [details]
Patch

r=me
Comment 3 WebKit Commit Bot 2010-09-18 15:48:52 PDT 
Comment on attachment 67964 [details]
Patch

Clearing flags on attachment: 67964

Committed r67794: <http://trac.webkit.org/changeset/67794>
Comment 4 WebKit Commit Bot 2010-09-18 15:48:57 PDT 
All reviewed patches have been landed.  Closing bug.