Bug 46003 - [BREWMP] Fix a typo in key code name
Summary: [BREWMP] Fix a typo in key code name
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: Platform (show other bugs)
Version: 528+ (Nightly build)
Hardware: Other Other
: P2 Normal
Assignee: Nobody
URL:
Keywords:
Depends on:
Blocks: 33564
  Show dependency tree / graph
 
Reported: 2010-09-17 15:25 PDT by Kwang Yul Seo
Modified: 2010-09-18 18:05 PDT (History)
3 users (show)

See Also:

Attachments
Patch (1.18 KB, patch)
2010-09-17 15:26 PDT, Kwang Yul Seo 		commit-queue: commit-queue-
Details | Formatted Diff | Diff
View All Add an attachment (proposed patch, testcase, etc.)

Note You need to log in before you can comment on or make changes to this bug.
Description Kwang Yul Seo 2010-09-17 15:25:46 PDT 
AVK_CLR is the right Brew MP key code name for VK_BACK.
Comment 1 Kwang Yul Seo 2010-09-17 15:26:48 PDT 
Created attachment 67961 [details]
Patch
Comment 2 Andreas Kling 2010-09-17 19:09:45 PDT 
Comment on attachment 67961 [details]
Patch

r=me
Comment 3 Adam Barth 2010-09-18 17:47:14 PDT 
Comment on attachment 67961 [details]
Patch

Clearing flags on attachment: 67961

Committed r67803: <http://trac.webkit.org/changeset/67803>
Comment 4 Adam Barth 2010-09-18 17:47:19 PDT 
All reviewed patches have been landed.  Closing bug.
Comment 5 WebKit Commit Bot 2010-09-18 17:48:53 PDT 
Comment on attachment 67961 [details]
Patch

Rejecting patch 67961 from commit-queue.

Failed to run "[u'/Projects/CommitQueue/WebKitTools/Scripts/svn-apply', u'--force']" exit_code: 1
Parsed 2 diffs from patch file(s).
patching file WebCore/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebCore/platform/brew/PlatformKeyboardEventBrew.cpp
Hunk #1 FAILED at 106.
1 out of 1 hunk FAILED -- saving rejects to file WebCore/platform/brew/PlatformKeyboardEventBrew.cpp.rej

Full output: http://queues.webkit.org/results/4064060
Comment 6 Adam Barth 2010-09-18 18:05:21 PDT 
Interesting.  This patch hit a race condition in the commit-cluster.  I think the first commit-queue instance took long enough to process the patch that the lock was released.  Maybe we need to up the timeout?