Bug 45990 - Use AtomicString insted of String in XMLDocumentParser
Summary: Use AtomicString insted of String in XMLDocumentParser
Status: RESOLVED FIXED
Alias: None
Product: WebKit
Classification: Unclassified
Component: XML (show other bugs)
Version: 528+ (Nightly build)
Hardware: All All
: P2 Normal
Assignee: Patrick R. Gansterer
URL:
Keywords:
Depends on:
Blocks: 43085
  Show dependency treegraph
 
Reported: 2010-09-17 13:29 PDT by Patrick R. Gansterer
Modified: 2010-10-09 12:01 PDT (History)
6 users (show)

See Also:


Attachments
Patch (5.40 KB, patch)
2010-09-17 13:45 PDT, Patrick R. Gansterer
abarth: review-
Details | Formatted Diff | Diff
Patch (5.41 KB, patch)
2010-09-18 01:16 PDT, Patrick R. Gansterer
no flags Details | Formatted Diff | Diff

Note You need to log in before you can comment on or make changes to this bug.
Description Patrick R. Gansterer 2010-09-17 13:29:54 PDT
Creating AtomicString instead of String as early as possible should decrease the parsing time.
Comment 1 Patrick R. Gansterer 2010-09-17 13:45:44 PDT
Created attachment 67945 [details]
Patch

> +    // FIXME: Use AtomicString::fromUTF8.
> +    return AtomicString(toString(string));
Maybe we can commit now and change this when bug 45594 is finished?
Comment 2 WebKit Review Bot 2010-09-17 16:23:48 PDT
Attachment 67945 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/4071053
Comment 3 WebKit Review Bot 2010-09-17 16:36:08 PDT
Attachment 67945 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/4000034
Comment 4 Adam Barth 2010-09-17 16:43:03 PDT
Comment on attachment 67945 [details]
Patch

Does not compile.
Comment 5 Patrick R. Gansterer 2010-09-18 01:16:26 PDT
Created attachment 68001 [details]
Patch

Should build now.
Comment 6 WebKit Commit Bot 2010-09-18 18:45:04 PDT
Comment on attachment 68001 [details]
Patch

Rejecting patch 68001 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--quiet']" exit_code: 1
Last 500 characters of output:
outTests
Testing 21315 test cases.
websocket/tests/frame-length-skip.html -> timed out
Sampling process 10878 for 10 seconds with 10 milliseconds of run time between samples
Sampling completed, processing symbols...
Sample analysis of process 10878 written to file /Users/eseidel/Library/Logs/DumpRenderTree/HangReport.txt

Exiting early after 1 failures. 21281 tests run.
586.09s total testing time

21280 test cases (99%) succeeded
1 test case (<1%) timed out
33 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/4086008
Comment 7 Adam Barth 2010-09-18 20:02:07 PDT
Comment on attachment 68001 [details]
Patch

Clearing flags on attachment: 68001

Committed r67807: <http://trac.webkit.org/changeset/67807>
Comment 8 Adam Barth 2010-09-18 20:02:12 PDT
All reviewed patches have been landed.  Closing bug.