Bug 45990 – Use AtomicString insted of String in XMLDocumentParser

• Status: RESOLVED
• Resolution: FIXED
• Component: XML

[Patrick R. Gansterer]

Creating AtomicString instead of String as early as possible should decrease the parsing time.

[Patrick R. Gansterer]

Created attachment 67945 [details]
Patch

> +    // FIXME: Use AtomicString::fromUTF8.
> +    return AtomicString(toString(string));
Maybe we can commit now and change this when bug 45594 is finished?

[WebKit Review Bot]

Attachment 67945 [details] did not build on gtk:
Build output: http://queues.webkit.org/results/4071053

[WebKit Review Bot]

Attachment 67945 [details] did not build on chromium:
Build output: http://queues.webkit.org/results/4000034

[Adam Barth]

Comment on attachment 67945 [details]
Patch

Does not compile.

[Patrick R. Gansterer]

Created attachment 68001 [details]
Patch

Should build now.

[WebKit Commit Bot]

Comment on attachment 68001 [details]
Patch

Rejecting patch 68001 from commit-queue.

Failed to run "['WebKitTools/Scripts/run-webkit-tests', '--no-launch-safari', '--exit-after-n-failures=1', '--wait-for-httpd', '--quiet']" exit_code: 1
Last 500 characters of output:
outTests
Testing 21315 test cases.
websocket/tests/frame-length-skip.html -> timed out
Sampling process 10878 for 10 seconds with 10 milliseconds of run time between samples
Sampling completed, processing symbols...
Sample analysis of process 10878 written to file /Users/eseidel/Library/Logs/DumpRenderTree/HangReport.txt

Exiting early after 1 failures. 21281 tests run.
586.09s total testing time

21280 test cases (99%) succeeded
1 test case (<1%) timed out
33 test cases (<1%) had stderr output

Full output: http://queues.webkit.org/results/4086008

[Adam Barth]

Comment on attachment 68001 [details]
Patch

Clearing flags on attachment: 68001

Committed r67807: <http://trac.webkit.org/changeset/67807>

[Adam Barth]

All reviewed patches have been landed.  Closing bug.