RESOLVED FIXED 45976
In GraphicsContext, drawImage's use of -1 for non-specified widths/heights disallows usage of -1 
https://bugs.webkit.org/show_bug.cgi?id=45976
Summary In GraphicsContext, drawImage's use of -1 for non-specified widths/heights di...
Matthew Delaney
Reported Friday, September 17, 2010 6:57:33 PM UTC
I noticed that the underlying canvasrenderingcontext2d drawImage and drawImageBuffer calls used the value -1 to in-band signal when the width/height wasn't specified and thus should be interpreted as image.width and image.height respectively. This causes the case where the actual width/height params come in as -1 from the call to context.drawImage to render incorrectly.
Attachments
Negative 1 Source and Dest Test Cases (8.03 KB, application/zip)
2010-09-17 11:39 PDT, Matthew Delaney 		no flags
Details
Patch (14.14 KB, patch)
2010-09-17 12:54 PDT, Matthew Delaney 		no flags
DetailsFormatted DiffDiff
View All Add attachment proposed patch, testcase, etc.
Simon Fraser (smfr)
Comment 1 Friday, September 17, 2010 7:22:04 PM UTC
Testcase?
Matthew Delaney
Comment 2 Friday, September 17, 2010 7:39:27 PM UTC
Created attachment 67925 [details] Negative 1 Source and Dest Test Cases Two test cases. One showing the problem of having source width and height as negative 1 and the other with the dest width and height as negative one.
Matthew Delaney
Comment 3 Friday, September 17, 2010 8:54:00 PM UTC
Created attachment 67940 [details] Patch
Oliver Hunt
Comment 4 Friday, September 17, 2010 11:32:26 PM UTC
Comment on attachment 67940 [details] Patch r=me
WebKit Commit Bot
Comment 5 Saturday, September 18, 2010 10:47:13 PM UTC
Comment on attachment 67940 [details] Patch Clearing flags on attachment: 67940 Committed r67792: <http://trac.webkit.org/changeset/67792>
WebKit Commit Bot
Comment 6 Saturday, September 18, 2010 10:47:18 PM UTC
All reviewed patches have been landed. Closing bug.
WebKit Review Bot
Comment 7 Sunday, September 19, 2010 12:02:24 AM UTC
http://trac.webkit.org/changeset/67792 might have broken GTK Linux 64-bit Debug
Dimitri Glazkov (Google)
Comment 8 Sunday, September 19, 2010 12:43:24 AM UTC
This broke a bunch of SVG tests (pixel results, so not really seen in the waterfall). You can see failures on Chromium Tests build bots that do run pixel tests. For example: http://test-results.appspot.com/dashboards/flakiness_dashboard.html#upstreamWebKit=true&tests=svg%2Ffilters%2FfeTile.svg&showExpectations=true&showLargeExpectations=true It looks like they just stopped drawing.
Dimitri Glazkov (Google)
Comment 9 Sunday, September 19, 2010 12:49:23 AM UTC
Reverted r67792 for reason: Broke over a hundred SVG tests. Committed r67799: <http://trac.webkit.org/changeset/67799>
Philip Rogers
Comment 10 Sunday, February 10, 2013 3:16:13 AM UTC
This was fixed independently with http://trac.webkit.org/changeset/139911
Note You need to log in before you can comment on or make changes to this bug.